InstructorCourseStudentDetailsEdit: wrong student is edited after page is reloaded due to existing email error

[damithc]

From arnold.k...@gmail.com on February 07, 2014 15:14:33

Attempting to edit a student's email to an existing email, failing, and attempting further edits will cause the owner of the existing email to be edited Cause: When the page is reloaded to show the error message, the existing email is entered in the email field, causing the owner of the email field to be the target of editing if the save action is invoked another time.

Original issue: http://code.google.com/p/teammatespes/issues/detail?id=1595

[damithc]

From arnold.k...@gmail.com on March 03, 2014 18:18:30

Lifu, you can tackle this next.

Owner: wulifu20...@gmail.com

[damithc]

From wulifu20...@gmail.com on March 03, 2014 18:21:34

ok will look at it later

Cc: arnold.k...@gmail.com

[damithc]

From wulifu20...@gmail.com on March 05, 2014 03:01:48

Status: Started
Cc: -arnold.k...@gmail.com

[damithc]

From wulifu20...@gmail.com on March 05, 2014 04:28:19

As we can see from the screen shot, after failing to update with an existing email, the email address which is used as an identifier is forced back to the original one (thus the email address input box shows the original one) thus the problem is solved https://codereview.appspot.com/67910048 http://4-18-dot-teammates-lifu.appspot.com/

Status: ReadyForReview
Cc: arnold.k...@gmail.com

Attachment: Screen Shot 2014-03-05 at 8.22.11 pm.png

[damithc]

From arnold.k...@gmail.com on March 05, 2014 04:41:59

Is it possible to keep the duplicate email in the input box and yet not encounter this problem? The duplicate email might be caused by a typo and we don't want to force the instructor to retye the whole thing and make the same typo.

Status: ChangesRequested

[damithc]

From arnold.k...@gmail.com on March 09, 2014 23:28:19

Labels: Reviewer-Arnold

[damithc]

From wulifu20...@gmail.com on March 12, 2014 06:10:41

I've fixed the problem. But pls take a look at the code to see whether the changes I've made are appropriate

Status: ReadyForReview

[damithc]

From arnold.k...@gmail.com on March 12, 2014 06:39:10

Comments added. You also need to create a test for this, both in the UI test and in the Action test.

Status: ChangesRequested

[damithc]

From wulifu20...@gmail.com on March 12, 2014 07:18:02

Hi Arnold in your comment "arnold.koroa 2014/03/12 13:38:18 You can do this in the Action. If there's no email conflict just assign newEmail as the student's email" which action are you referring to?

[damithc]

From arnold.k...@gmail.com on March 12, 2014 19:16:53

The Action class that produces the page, which is InstructorCourseStudentDetailsEditSaveAction

[damithc]

From arnold.k...@gmail.com on March 20, 2014 23:10:57

Lifu, how's progress? Next week will be my last week in Singpaore so it'd be good if you can finish by then ;)

[damithc]

From wulifu20...@gmail.com on March 22, 2014 21:06:24

Hi Arnold sorry I'm quite busy recently, I'll try my best to give it a try so that I can discuss with you this coming Wed if I have problem

[damithc]

From arnold.k...@gmail.com on April 03, 2014 04:14:18

James should take over so you won't be delayed if I'm not able to review for a while

Cc: -arnold.k...@gmail.com jamesdju...@gmail.com
Labels: -Reviewer-Arnold Reviewer-James

[damithc]

From wulifu20...@gmail.com on April 09, 2014 04:25:04

https://codereview.appspot.com/67910048

Status: ReadyForReview

[damithc]

From jamesdju...@gmail.com on April 09, 2014 04:55:55

This issue was updated by revision f2eae38cc065 .

Status: Delivered

[damithc]

From dam...@gmail.com on April 11, 2014 22:46:37

Status: Deployed
Labels: Milestone-V4.96