nus-oss-test / testrepo4

TEAMMATES system is online at
http://teammatesv4.appspot.com
0 stars 0 forks source link

Enrolling multiple with the same email will enroll the first students' email using the last students data #1667

Closed damithc closed 10 years ago

damithc commented 10 years ago

From arnold.k...@gmail.com on February 07, 2014 15:51:29

For example Team 1 Student1 stud1@course.com Team 2 Student2 stud1@course.com Team 3 Student3 stud1@course.com

Will result with the following student being created Team3 Student3 stud1@course.com

I think the enrolling should be blocked instead?

Original issue: http://code.google.com/p/teammatespes/issues/detail?id=1596

damithc commented 10 years ago

From dam...@gmail.com on February 07, 2014 03:43:04

Yes, it is better to block and inform that there is duplication.

damithc commented 10 years ago

From arnold.k...@gmail.com on February 19, 2014 02:44:28

Owner: Vivian.X...@gmail.com

damithc commented 10 years ago

From Vivian.X...@gmail.com on February 19, 2014 05:03:33

Status: Started

damithc commented 10 years ago

From Vivian.X...@gmail.com on March 05, 2014 02:59:38

https://codereview.appspot.com/71510043/

Status: ReadyForReview

damithc commented 10 years ago

From arnold.k...@gmail.com on March 05, 2014 19:36:38

Add a test to check if duplicate emails really results in an error

Status: ChangesRequested

damithc commented 10 years ago

From arnold.k...@gmail.com on March 05, 2014 23:25:55

Issue 1357 has been merged into this issue.

damithc commented 10 years ago

From Vivian.X...@gmail.com on March 07, 2014 00:43:51

test case added

Status: ReadyForReview

damithc commented 10 years ago

From arnold.k...@gmail.com on March 09, 2014 20:01:34

Good job :) Can you merge the default branch to your branch and reupload the patch? The trunk has changed too much and I can't apply your patch anymore.

Status: ChangesRequested

damithc commented 10 years ago

From Vivian.X...@gmail.com on March 09, 2014 21:22:57

Status: ReadyForReview

damithc commented 10 years ago

From arnold.k...@gmail.com on March 09, 2014 22:02:13

This issue was updated by revision 7531e9738513 .

Status: Delivered

damithc commented 10 years ago

From dam...@gmail.com on March 14, 2014 23:34:42

Status: Deployed
Labels: Milestone-V4.91