Update DevMan: upload.py doesn't work with executable flag on

[damithc]

From quahu...@gmail.com on February 12, 2014 19:45:18

On linux (and probably in Mac), when set executable, upload.py uploads itself to the code review system and hangs at "Uploading base file for upload.py".

Instead of setting executable permission and then run upload.py, an alternative way is to do:

python upload.py

and pass whatever arguments needed. This should be updated in the devman.

Original issue: http://code.google.com/p/teammatespes/issues/detail?id=1609

[damithc]

From arnold.k...@gmail.com on February 12, 2014 18:54:46

This should also avoid the confusion due to an empty diff being uploaded to the review site.

upload.py with executable mode does work on amc but it will upload an empty diff for upload.py to the review site.

Status: Accepted
Labels: SuitableAsFirstIssue

[damithc]

From arnold.k...@gmail.com on February 13, 2014 00:42:45

Oh, Huynh, this is too easy for you, pick something harder :P

Summary: Update DevMan: upload.py doesn't work with executable flag on (was: upload.py doesn't work with executable flag on)
Owner: ---

[damithc]

From quahu...@gmail.com on February 13, 2014 03:06:24

Sure, no problem :)

[damithc]

From dam...@gmail.com on March 02, 2014 07:54:50

Tania, here's an easy issue for you to start with.

Owner: tchatter...@gmail.com
Cc: arnold.k...@gmail.com
Labels: Reviewer-Arnold

[damithc]

From tchatter...@gmail.com on March 02, 2014 16:20:17

Status: Started

[damithc]

From tchatter...@gmail.com on March 04, 2014 04:08:56

https://codereview.appspot.com/69930047/

Status: ReadyForReview

[damithc]

From arnold.k...@gmail.com on March 04, 2014 08:02:23

Hi Tania. Please merge the latest commit in the default branch to your branch first before uploading the patch. Otherwise changes committed after you branched out from default will be undone by your patch.

Status: ChangesRequested

[damithc]

From arnold.k...@gmail.com on March 04, 2014 08:14:24

also added comments at review site

[damithc]

From tchatter...@gmail.com on March 05, 2014 06:04:50

Hi Arnold,

In the previous changeset, I did not make this change.

gaeLaunchAppInBrowser=true

I am wondering why it appeared in the diff. Nevertheless, I reverted it and also made the changes you suggested. Link to the code review system: https://codereview.appspot.com/67910049/ Thank you!

Status: ReadyForReview

[damithc]

From arnold.k...@gmail.com on March 05, 2014 07:47:37

Hi Tania, use the -i flag for upload.py so I can see the diff against the previous patch. See DevMan for details :)

Status: ChangesRequested

[damithc]

From tchatter...@gmail.com on March 05, 2014 08:28:51

I used -i with the issue id of the 1st changeset (69930047). Is it ok? https://codereview.appspot.com/69930047/

Status: ReadyForReview

[damithc]

From arnold.k...@gmail.com on March 05, 2014 19:23:23

Yes, that's correct :) Added comments at the review site

Status: ChangesRequested

[damithc]

From tchatter...@gmail.com on March 05, 2014 20:47:54

https://codereview.appspot.com/69930047/

Status: ReadyForReview

[damithc]

From arnold.k...@gmail.com on March 05, 2014 23:22:46

Some cosmetic changes left :)

Status: ChangesRequested

[damithc]

From tchatter...@gmail.com on March 06, 2014 04:50:18

https://codereview.appspot.com/69930047/

Status: ReadyForReview

[damithc]

From arnold.k...@gmail.com on March 06, 2014 18:46:18

This issue was updated by revision 6d6841f0276b .

Status: Delivered

[damithc]

From tchatter...@gmail.com on March 07, 2014 07:34:28

Thanks for your help and guidance, Arnold. :)

[damithc]

From dam...@gmail.com on March 07, 2014 21:40:26

Status: Deployed
Labels: Milestone-V4.90