search

nus-oss-test / testrepo4

TEAMMATES system is online at
http://teammatesv4.appspot.com
0 stars 0 forks source link

Create missing Action tests #1689

Closed damithc closed 10 years ago

damithc commented 10 years ago

From arnold.k...@gmail.com on February 19, 2014 14:59:45

Feedback Remind, Eval/Feedback Preview, Join Confirmation,

Original issue: http://code.google.com/p/teammatespes/issues/detail?id=1624

damithc commented 10 years ago

From arnold.k...@gmail.com on February 18, 2014 23:01:31

Summary: Create Action tests for Feedback Remind, Eval/Feedback Preview and Join Confirmation Actions (was: Create Action tests for the new Actions)

damithc commented 10 years ago

From arnold.k...@gmail.com on March 19, 2014 23:33:53

Issue 1035 has been merged into this issue.

damithc commented 10 years ago

From arnold.k...@gmail.com on March 19, 2014 23:37:11

InstructorFeedbackPublishAction InstructorFeedbackUnpublishAction InstructorFeedbackDownloadAction InstructorFeedbackRemindAction InstructorEvalPreviewAction InstructorFeedbackPreviewAsStudent.InstructorAction StudentCourseJoinAuthenticatedAction

Summary: Create missing Action tests (was: Create Action tests for Feedback Remind, Eval/Feedback Preview and Join Confirmation Actions)
Status: Started

damithc commented 10 years ago

From arnold.k...@gmail.com on March 20, 2014 02:18:24

https://codereview.appspot.com/78110044/ Seems like for the tests mentioned above even the Evaluation side does not have testExcecuteAndPostProcess implemented. For now I will do testAccessControl for all of them first and open an issue to implement testExcecuteAndPostProcess for each of the action. Then I will do them one by one but I'm not sure I can finish every sigle one by tomorrow.

Status: ReadyForReview
Cc: dam...@gmail.com

damithc commented 10 years ago

From dam...@gmail.com on March 20, 2014 02:22:33

Do as many as you can, focusing more on critical ones (e.g. ones that writes to the datastore) :-)

Status: ReadyToMerge

damithc commented 10 years ago

From arnold.k...@gmail.com on March 20, 2014 19:19:35

This issue was updated by revision 2428ce06e59f .

Status: Delivered

damithc commented 10 years ago

From dam...@gmail.com on March 22, 2014 05:50:54

Status: Deployed
Labels: Milestone-V4.93