nus-oss-test / testrepo4

TEAMMATES system is online at
http://teammatesv4.appspot.com
0 stars 0 forks source link

Show placeholder course in student home page if course join is affected by eventual consistency #1693

Closed damithc closed 10 years ago

damithc commented 10 years ago

From leeshaw...@gmail.com on February 20, 2014 22:10:03

When a student joins a course, the confirmation data might be affected by eventual consistency. As a result, the student will be unable to see the course in the student home page.

Instead of showing a "please wait" message here, we can still show the course in the home page even if the database is not updated since we already have confirmation that the student has successfully joined the course.

Original issue: http://code.google.com/p/teammatespes/issues/detail?id=1630

damithc commented 10 years ago

From leeshaw...@gmail.com on February 21, 2014 05:05:47

Status: Started

damithc commented 10 years ago

From leeshaw...@gmail.com on February 22, 2014 02:13:27

Student home page will now display a placeholder course if the course join is detected to be affected by eventual consistency.

The evaluations and feedback sessions for the respective course are also populated, but with default values (pending, closed or publised) since it is not possible to get the student's submission since it is affected by eventual consistency.

Currently, if by the time the student clicks on the placeholder course and the data is still inconsistent, the respective pages will handle the action with their own status messages. I will check in a separate issue places where such actions take place and replace the status messages with an eventual consistency message when required.

Code ready for review at: https://codereview.appspot.com/67020045

Status: ReadyForReview

damithc commented 10 years ago

From dam...@gmail.com on February 22, 2014 22:18:18

I'm not clear what you mean by "respective course are also populated, but with default values (pending, closed or publised)". This data is currently available in the database and not affected by eventual consistency. If the student is just joining the course, we can assume that he hasn't submitted anything for that course yet.

Status: ReadyToMerge

damithc commented 10 years ago

From leeshaw...@gmail.com on February 22, 2014 22:29:27

Oh yes I forgot that we can make that assumption. I was probably too focused on trying to figure out the different cases when a student joins the course.

damithc commented 10 years ago

From leeshaw...@gmail.com on February 22, 2014 23:34:53

This issue was updated by revision ed891d9c91b7 .

damithc commented 10 years ago

From leeshaw...@gmail.com on February 22, 2014 23:37:54

Status: Delivered

damithc commented 10 years ago

From leeshaw...@gmail.com on February 26, 2014 01:58:40

This issue was updated by revision ed891d9c91b7 .

damithc commented 10 years ago

From dam...@gmail.com on February 26, 2014 02:50:58

Status: Deployed

damithc commented 10 years ago

From dam...@gmail.com on February 26, 2014 02:51:37

Status: Delivered

damithc commented 10 years ago

From dam...@gmail.com on February 28, 2014 19:05:14

Status: Deployed
Labels: Milestone-V4.89