search

nus-oss-test / testrepo4

TEAMMATES system is online at
http://teammatesv4.appspot.com
0 stars 0 forks source link

Send Feedback Session Published Email Reminder only to students who has something new to see #1701

Closed damithc closed 10 years ago

damithc commented 10 years ago

From arnold.k...@gmail.com on February 24, 2014 11:37:50

Currently it is sent to all students regardless of whether or not they have anything to see as long as the session is newly published

Original issue: http://code.google.com/p/teammatespes/issues/detail?id=1641

damithc commented 10 years ago

From arnold.k...@gmail.com on February 24, 2014 01:11:32

https://codereview.appspot.com/68040043/

Status: ReadyForReview
Cc: dam...@gmail.com

damithc commented 10 years ago

From dam...@gmail.com on February 24, 2014 01:32:55

Need tests for this one. Bugs in this feature can go unnoticed for a while.

Status: ChangesRequested

damithc commented 10 years ago

From arnold.k...@gmail.com on February 26, 2014 21:51:18

Is this message ok for students who have nothing new to see?

Attachment: Untitled picture.png

damithc commented 10 years ago

From arnold.k...@gmail.com on February 26, 2014 22:23:15

https://codereview.appspot.com/69010045/

Status: ReadyForReview

damithc commented 10 years ago

From dam...@gmail.com on February 26, 2014 22:30:36

They are going to click the link before reading the text that follows :-p. Better to have a totally different text '... you have no responses... to view your own submissions, go to ...'

damithc commented 10 years ago

From arnold.k...@gmail.com on February 26, 2014 22:56:17

Will moving the message up serve the same purpose? Changing the whole message will require passing the information of who have/don't have new responses to a generic method that does the url replacement, which will affect all other email methods even though they have no need for the extra information.

Attachment: Untitled picture.png

damithc commented 10 years ago

From dam...@gmail.com on February 26, 2014 23:01:28

This one should work.

damithc commented 10 years ago

From arnold.k...@gmail.com on February 26, 2014 23:29:51

https://codereview.appspot.com/69010045/

damithc commented 10 years ago

From dam...@gmail.com on February 26, 2014 23:35:46

Status: ReadyToMerge

damithc commented 10 years ago

From arnold.k...@gmail.com on February 26, 2014 23:42:54

This issue was updated by revision 08b66e17bd75 .

Status: Delivered

damithc commented 10 years ago

From dam...@gmail.com on February 28, 2014 19:05:14

Status: Deployed
Labels: Milestone-V4.89

damithc commented 10 years ago

From arnold.k...@gmail.com on March 13, 2014 22:14:48

This issue was updated by revision f7a7facba366 . Backed out in issue 1716