search

nus-oss-test / testrepo4

TEAMMATES system is online at
http://teammatesv4.appspot.com
0 stars 0 forks source link

InstructorFeedbackResultDownload: add team column to the csv file #1703

Closed damithc closed 10 years ago

damithc commented 10 years ago

From dam...@gmail.com on February 24, 2014 17:42:28

It will make the post processing of the csv file by the instructor much easier.

Original issue: http://code.google.com/p/teammatespes/issues/detail?id=1643

damithc commented 10 years ago

From dam...@gmail.com on February 27, 2014 17:46:03

Requested by user. Should be ready before April. Arnold, may be assign to a contributor?

Cc: arnold.k...@gmail.com
Labels: -Priority-Medium Priority-High

damithc commented 10 years ago

From dam...@gmail.com on March 02, 2014 20:33:37

Kai, try this one.

Owner: Gigi...@gmail.com
Labels: Reviewer-Arnold

damithc commented 10 years ago

From Gigi...@gmail.com on March 02, 2014 20:58:29

Status: Started

damithc commented 10 years ago

From Gigi...@gmail.com on March 03, 2014 21:57:09

Code review: https://codereview.appspot.com/71070043/ Csv preview:

Status: ReadyForReview

Attachment: Screen Shot 2014-03-04 at 12.54.01 pm.png

damithc commented 10 years ago

From dam...@gmail.com on March 03, 2014 22:24:34

Output looks good. I prefer a cleaner implementation though.

Status: ChangesRequested
Labels: -Reviewer-Arnold

damithc commented 10 years ago

From Gigi...@gmail.com on March 03, 2014 23:11:08

Noted. I will try to make it like: the results returned by getFeedbackSessionResultsForUser will always contain the team column information.

So that other programmers can use it to enhance ui in the future

Status: Started

damithc commented 10 years ago

From Gigi...@gmail.com on March 04, 2014 01:16:37

Code review: https://codereview.appspot.com/71070043/

Status: ReadyForReview

damithc commented 10 years ago

From dam...@gmail.com on March 04, 2014 07:14:32

Looks good. Minor cosmetic change requested.

Status: ChangesRequested

damithc commented 10 years ago

From Gigi...@gmail.com on March 04, 2014 17:13:11

Code review: https://codereview.appspot.com/71070043/ some changes:

  1. add a description for that function
  2. rename it with a slightly better name
  3. remove early return; now return part at the end is more readable

Status: ReadyForReview

damithc commented 10 years ago

From dam...@gmail.com on March 04, 2014 19:49:54

Status: ReadyToMerge

damithc commented 10 years ago

From arnold.k...@gmail.com on March 05, 2014 07:20:07

This issue was updated by revision 26bce273ed1a .

Status: Delivered

damithc commented 10 years ago

From dam...@gmail.com on March 07, 2014 21:40:27

Status: Deployed
Labels: Milestone-V4.90