Students cannot see team feedback submitted by thir own team

[damithc]

From arnold.k...@gmail.com on February 27, 2014 12:16:24

In team to team feedback, students cannot see the feedback submitted by their own team in the results page.

Original issue: http://code.google.com/p/teammatespes/issues/detail?id=1648

[damithc]

From Gigi...@gmail.com on March 14, 2014 21:02:44

Code review: https://codereview.appspot.com/76360043/ the cause is removeIrrelevantVisibilityOptions() in FeedbackQuestionAttributes. it removes the visibility, so students then cannot see.

removeIrrelevantVisibilityOptions() also causes another problem in instructorFeedbackEdit: when it's Team-related question, OWN_TEAM_MEMBERS and RECEIVER_TEAM_MEMBERS may be always removed in Visibility Options

[damithc]

From dam...@gmail.com on March 14, 2014 22:53:01

Status: ReadyForReview
Owner: Gigi...@gmail.com
Cc: arnold.k...@gmail.com
Labels: Reviewer-Arnold

[damithc]

From arnold.k...@gmail.com on March 17, 2014 22:23:39

I don't think that's right. When it's team to team the giver/recipient is the team. A team does not have teammates so OWN_TEAM_MEMBERS and RECIPIENT_TEAM_MEMBERS is not supposed to be included (their name is rather misleading, it should be giver_teammates and receiver_teammates).

Instead, when getting the results of the session, it should be checked if this is a team question and in that case query for responses given by the user's team and include it in the results list.

I encountered this error while writing a back-end test so it's not a UI issue.

Status: ChangesRequested

[damithc]

From Gigi...@gmail.com on March 17, 2014 23:13:29

Hi Arnold,

yes it's not a UI issue.

1. Sorry, what does "A team does not have teammates" mean? An empty team?
2. now in getViewableFeedbackResponsesForStudentForQuestion() of teammates.logic.core.FeedbackResponsesLogic,

when question's giver/recipient is a team, it will check whether there is OWN_TEAM_MEMBERS in showResponsesTo attribute (probably means: is visible to own team members). if it has, then this question will be added and later will be displayed to giver's teammates. if it doesn't have, this question will not be displayed to teammates. And similar process for RECEIVER_TEAM_MEMBERS (is visible to receiver's teammates).

So I feel my understanding about OWN_TEAM_MEMBERS and RECIPIENT_TEAM_MEMBERS is right.

[damithc]

From Gigi...@gmail.com on March 17, 2014 23:22:11

Or you mean, if its giver/recipient is a team, then all members in that team should be able to see it?

[damithc]

From arnold.k...@gmail.com on March 17, 2014 23:23:33

1. Sorry, what does "A team does not have teammates" mean? An empty team? I mean, there's the students (Alice, Benny, Charlie, etc) and there's the team (Team 1, Team2, etc). A team has members (ie students) but does not have teammates. Students have teammates (ie other students in the same team)
2. ... Hmm, ok, seems like you are right. Anyway after I checked OWN_TEAM is not a valid viewer so what I said above can't be correct. However, I think it is necessary

In this case your fix above should be able to fix any future questions involving teams. However, it is necessary to force OWN_TEAM_MEMBERS to always be able to see the feedback when it's a team-to-team question. Does the UI enforce that currently? Or can you untick the option?

[damithc]

From arnold.k...@gmail.com on March 17, 2014 23:25:03

Or you mean, if its giver/recipient is a team, then all members in that team should be able to see it?

Yes, that is the intended behaviout

[damithc]

From Gigi...@gmail.com on March 17, 2014 23:27:30

Yes, that is the intended behaviout

noted

Status: Started

[damithc]

From dam...@gmail.com on March 17, 2014 23:32:04

Let's say receiver is a team and the response is visible to receiver. In that case, all team members of receiving team should be able to see it irrespective of 'recipient team members' is ticked or not.

[damithc]

From Gigi...@gmail.com on March 18, 2014 09:37:43

Code review: https://codereview.appspot.com/76360043/

Status: ReadyForReview

[damithc]

From arnold.k...@gmail.com on March 18, 2014 19:40:50

The changes looks good.

In addition to that though, I think we should pre-tick and hide the visibility options for Giver's Team members when creating from-team questions as now the response is always visible to the giver team regardless of whether or not it's ticked in the option table. We shouldn't mislead the instructor into thinking he can hide it from the giver team.

Status: ChangesRequested

Attachment: Untitled picture.png

[damithc]

From Gigi...@gmail.com on March 18, 2014 22:22:22

Code review: https://codereview.appspot.com/76360043/ 1. as pre-tick for Team (giver) has no effect (they are always filtered), I just hide the row "Giver's Team Members"

1. I also fix a bug in visibility options: for an existing question, it always display 5 options no matter what type's selected

both ui testing added

Status: ReadyForReview

[damithc]

From arnold.k...@gmail.com on March 19, 2014 19:55:57

This issue was updated by revision 74b03ff62e99 .

Status: Delivered

[damithc]

From dam...@gmail.com on March 20, 2014 04:59:55

Status: Deployed
Labels: Milestone-V4.92