Closed damithc closed 10 years ago
From leeshaw...@gmail.com on March 17, 2014 07:43:52
Status: Started
From leeshaw...@gmail.com on March 18, 2014 00:42:29
Checked all the servlets and related action files and added logging for exceptions to those that does not have any logging yet. Part of this issue was already fixed by hunar in Issue 1714 .
Code ready for review at: https://codereview.appspot.com/76010044
Status: ReadyForReview
From dam...@gmail.com on March 18, 2014 00:48:40
Is it better to have a parent class for all these servletes (excluding the ControllerServlet) to catch all exceptions and log them? We do something similar in the ControllerServlet to catch all exceptions from the Action classes. We'll discuss tomorrow.
From dam...@gmail.com on March 19, 2014 16:51:19
Status: ChangesRequested
From leeshaw...@gmail.com on March 20, 2014 06:23:48
Added a base WorkerServlet class as the parent class for *WorkerServlets. Also added exception handling to the 2 base classes, WorkerServlet and AutomatedRemindersServlet.
Code ready for review at: https://codereview.appspot.com/76010044
Status: ReadyForReview
From dam...@gmail.com on March 20, 2014 07:48:26
Status: ReadyToMerge
From leeshaw...@gmail.com on March 20, 2014 10:02:53
This issue was updated by revision 6f9e3c140ae9 .
From leeshaw...@gmail.com on March 20, 2014 10:03:47
Status: Delivered
From dam...@gmail.com on March 22, 2014 05:50:54
Status: Deployed
Labels: Milestone-V4.93
From dam...@gmail.com on February 27, 2014 14:57:49
Need to catch exceptions in Servlets (e.g. *WorkerServlet) and log under severe. Otherwise they can go unnoticed.
Original issue: http://code.google.com/p/teammatespes/issues/detail?id=1650