InstructorFeedbackPageUiTest fails to to differing status

[damithc]

From arnold.k...@gmail.com on March 03, 2014 11:34:48

one of the feedback session has a "Visible" status instead of the expected "Awaiting" status. Is this status (Visible) new? I don't recall seeing it before. The session is not yet open and is as far as I know should be labeled as "Awaiting"

This bug exists in the latest V4.89 release code.

Original issue: http://code.google.com/p/teammatespes/issues/detail?id=1661

[damithc]

From dam...@gmail.com on March 02, 2014 19:56:41

It should be awaiting. 'Visible' was used sometime back but we decided to change it to awaiting.

[damithc]

From arnold.k...@gmail.com on March 05, 2014 02:44:04

Owner: winsonta...@gmail.com

[damithc]

From winsonta...@gmail.com on March 05, 2014 02:50:09

Status: Started

[damithc]

From winsonta...@gmail.com on March 05, 2014 03:38:36

The issue arises because the visibleFromTime, which is hardcoded to be March 1, 2014, is no longer a date in the future.

The test passes if I change the dates to something in the future.

But, Dr. Damith, you mentioned that we no longer use 'visible' . Does this mean there is still something wrong with the code?

[damithc]

From dam...@gmail.com on March 05, 2014 03:50:22

It was supposed to be changed from 'Visible' to 'Awaiting', but we may have missed it in some places.

[damithc]

From winsonta...@gmail.com on March 05, 2014 11:23:10

https://codereview.appspot.com/71230048/ As a summary,

1. In PageData.java, +Changed 'Visible' status for feedback sessions to 'Awaiting'. Modified related test files.

2. In InstructorFeedbackPageUiTest.java, +I decided to change dates that were 2014: -If the dates need to be in future, changed to 2035 and add comment indicating so -else, change to other dates in the past Hence the dates are still hard-coded.

The following issues may be duplicates of existing ones, I haven't checked.

Issues faced when trying not to hard-code: +When using TimeHelper.getNextHour(), somehow the resulting dates is still considered to be in the past +TimeHelper.getDateOffsetToCurrentTime(offsetDays) produces a time whose minutes is not 00, hence not reproducible using the browser (which only allows 00 minutes), producing mismatch between savedSession and newSession. +Const.TIMEREPRESENTS* is not accepted as it is considered to be an invalid value. Also, its time value (which is 00:00 AM) is not reproducible using the browser (which only allows 2359), producing mismatch. +The expected date values in instructorFeedbackAddSuccess.html is hard-coded

Other issues observed: +some files that start with the word 'instructor' start with capital i, some start with small letter i +Files in main start with 'InstructorFeedbacks'. Test files start with 'InstructorFeedback' without 's'

Status: ReadyForReview

[damithc]

From arnold.k...@gmail.com on March 05, 2014 19:14:45

This issue was updated by revision 4c3e49676e3f .

Status: Delivered

[damithc]

From dam...@gmail.com on March 07, 2014 21:40:27

Status: Deployed
Labels: Milestone-V4.90