nus-oss-test / testrepo4

TEAMMATES system is online at
http://teammatesv4.appspot.com
0 stars 0 forks source link

InstructorEvalsPageUiTest fails when run with 'run all test' #1727

Closed damithc closed 10 years ago

damithc commented 10 years ago

From arnold.k...@gmail.com on March 04, 2014 13:18:29

This is because when run using run all test the test the VM is set to use UTC time zone, not the local time zone. Therefore when comparing with the evaluation created rom the UI, the comparson fails becuase the UI auto-detects and use the local time zone.

Should I change this such that the eval created from the UI is set to be in UTC as well?

When run individually the test runs in local time zone and passes.

Original issue: http://code.google.com/p/teammatespes/issues/detail?id=1672

damithc commented 10 years ago

From dam...@gmail.com on March 03, 2014 21:33:36

preferably, make it so that it passes in both modes. If that's not possible, it should pass when run individually because that is the fall back mode.

damithc commented 10 years ago

From arnold.k...@gmail.com on March 03, 2014 21:45:19

It's doable by changing the value of the timezone dropdown in the UI. Will fix this soon.

damithc commented 10 years ago

From arnold.k...@gmail.com on March 03, 2014 22:05:09

Status: Started

damithc commented 10 years ago

From arnold.k...@gmail.com on March 03, 2014 22:54:03

https://codereview.appspot.com/71090043/ I went back to hardcoding the tested time zone because selenium seem to randomly choose the wrong option when I sendKeys "UTC" to the dropdown as all the options starts with "UTC". Instead, I override the UI and choose the time zone according to the tested time zone. I also set the tested time zone to +5.75 so any problem with the hard-coding won't be missed just because most of us is in +8

Status: ReadyForReview

damithc commented 10 years ago

From dam...@gmail.com on March 03, 2014 23:10:35

Status: ReadyToMerge

damithc commented 10 years ago

From arnold.k...@gmail.com on March 03, 2014 23:13:26

This issue was updated by revision 5313a18bba97 .

Status: Delivered

damithc commented 10 years ago

From dam...@gmail.com on March 07, 2014 21:40:27

Status: Deployed
Labels: Milestone-V4.90