nus-oss-test / testrepo4

TEAMMATES system is online at
http://teammatesv4.appspot.com
0 stars 0 forks source link

instructorHome.jsp: address eclipse warning #1733

Closed damithc closed 10 years ago

damithc commented 10 years ago

From dam...@gmail.com on March 06, 2014 14:12:31

Warning: Attribute (name) is obsolete. Its use is discouraged in HTML5 documents.

Original issue: http://code.google.com/p/teammatespes/issues/detail?id=1682

damithc commented 10 years ago

From dam...@gmail.com on March 10, 2014 19:35:43

Staniloiu, have a go at this one. Shawn, assigned to you for reviewing.

Owner: edi33...@gmail.com
Cc: leeshaw...@gmail.com
Labels: Reviewer-Shawn

damithc commented 10 years ago

From edi33...@gmail.com on March 11, 2014 13:05:12

I have just arrived home from today's college hours. I am updating my local repo now and will start right away.

damithc commented 10 years ago

From edi33...@gmail.com on March 11, 2014 14:53:03

Hello,

I have used the "name" attribute only once or twice until now, but as far as I know, it must be replaced with the "id" attribute since html5. Because the tag already has the value of the "id" attribute set to the value of the "name" attribute, all I have to do is to delete the "name" attribute. Am I right?

damithc commented 10 years ago

From edi33...@gmail.com on March 11, 2014 17:11:30

https://codereview.appspot.com/74300044/

Status: ReadyForReview

damithc commented 10 years ago

From leeshaw...@gmail.com on March 12, 2014 08:06:37

InstructorHomePageUiTest is breaking due to the change. Remove the "name" field from the expected output. Remember to run the tests to ensure that they pass after making some changes =P Sometime tests might need to be updated after some code changes.

Status: ChangesRequested

damithc commented 10 years ago

From edi33...@gmail.com on March 16, 2014 17:11:06

Hello

Sorry for the late fix.

Here is the link for the review: https://codereview.appspot.com/76680043/

Status: ReadyForReview

damithc commented 10 years ago

From leeshaw...@gmail.com on March 17, 2014 07:34:49

Just a few minor things that needs to be changed. The files build.properties, appengine-web.xml and test.properties are used by you (as they are created from the templates), so they should not be committed. Also, there are some modifications to files like .project and index.html that can be omitted. Check the comments in the patch for more info =)

Status: ChangesRequested

damithc commented 10 years ago

From edi33...@gmail.com on March 17, 2014 08:14:09

I have made the changes and updated the patch. Also, I have included the link again, just in case =).

Sorry for the minor issues, but I am new to mercurial and I got confused with the commands. https://codereview.appspot.com/76680043/

Status: ReadyForReview

damithc commented 10 years ago

From leeshaw...@gmail.com on March 17, 2014 08:28:45

This issue was updated by revision 778be1a5405b .

damithc commented 10 years ago

From leeshaw...@gmail.com on March 17, 2014 08:29:16

Status: Delivered

damithc commented 10 years ago

From dam...@gmail.com on March 20, 2014 04:59:55

Status: Deployed
Labels: Milestone-V4.92