instructorCourseView: add 'comment' link to each student

[damithc]

From dam...@gmail.com on March 06, 2014 16:02:11

Can be a simple link to the 'All records' page, preferably cursor in the comment box already.

Original issue: http://code.google.com/p/teammatespes/issues/detail?id=1685

[damithc]

From dam...@gmail.com on March 06, 2014 00:02:20

Labels: SuitableAsFirstIssue

[damithc]

From dam...@gmail.com on March 08, 2014 06:15:45

Karan, have a go at this one. Please ask for help if needed.

Owner: KaranKam...@gmail.com
Cc: jamesdju...@gmail.com
Labels: Reviewer-James

[damithc]

From KaranKam...@gmail.com on March 08, 2014 10:09:27

Starting issue, exploring ways to add all records link in the course view's table for each student, as well as the right way to open the student record with the comment box opened. Planning to use the instructorStudentListPage as reference.

Status: Started

[damithc]

From KaranKam...@gmail.com on March 09, 2014 04:21:37

Made requisite changes. Added functionality for autofocus on Add Comment as well as redirect link from the courses tab.

Link to codereview code: https://codereview.appspot.com/72980044/

Status: ReadyForReview

[damithc]

From jamesdju...@gmail.com on March 09, 2014 05:04:43

Hi, the patch looks good, but you need to add in tests for the page to make sure that the link works. Also, to get the request parameter, use Java code instead of javascript, that's how we do it on all other pages.

Status: ChangesRequested

[damithc]

From dam...@gmail.com on March 09, 2014 05:43:44

As for the test, just need to click on one of the new links and make sure it goes to the right page.

[damithc]

From KaranKam...@gmail.com on March 09, 2014 11:42:13

Moved the request parameter getting to the Java code and added the test case for the comment link, as requested.

Link to codeview: https://codereview.appspot.com/72980044/

Status: ReadyForReview

[damithc]

From dam...@gmail.com on March 09, 2014 17:27:05

Karan, a quick comment while we wait for James to do a full review. You may want to verify that the page is indeed the page for that student. e.g. check the student name/email given in the page.

[damithc]

From KaranKam...@gmail.com on March 09, 2014 21:27:23

Changes made.

Note: Check also extends to other tests that use instructorStudentsRecordPage, and have been suitably updated to send in student name as a parameter for verification.

Link: https://codereview.appspot.com/72980044/

[damithc]

From jamesdju...@gmail.com on March 11, 2014 07:57:09

Status: ReadyToMerge

[damithc]

From arnold.k...@gmail.com on March 12, 2014 20:02:13

Hi Karan, the trunk has moved too much and I can no longer apply your patch. Can you merge the trunk to your branch and reupload the patch?

Status: ChangesRequested
Cc: arnold.k...@gmail.com

[damithc]

From KaranKam...@gmail.com on March 19, 2014 00:10:38

Have added the change for the test cases to make it consistent with the current branch. However, I'm having an issue pushing the changeset. update.py says : "No valid patches found in output from hg diff". I suspect this is because of the merge with the default registering as a commit on the default and not the issue branch. I'm unable to undo the merge. hg rollback does not work for merges.

[damithc]

From dam...@gmail.com on March 19, 2014 00:14:40

yes, that's the cause. If that commit (in the default branch) doesn't contain anything important, you can try to 'strip' it. i.e. delete it. TortoiseHg has the strip feature. There may be an equivalent in other GUIs.

[damithc]

From KaranKam...@gmail.com on March 19, 2014 02:41:28

Thanks professor. Made requisite changes. src/test/resources/pages/instructorStudentRecordsPageWithPrivateFeedback.html updated and merge conflicts resolved.

Status: ReadyForReview

[damithc]

From jamesdju...@gmail.com on March 19, 2014 05:52:49

Status: ChangesRequested

[damithc]

From KaranKam...@gmail.com on March 20, 2014 06:22:17

Hello James, May I know what requested changes are pending?

[damithc]

From jamesdju...@gmail.com on March 20, 2014 06:38:44

Ah, sorry.. I forgot to publish my comment :p. Can you see it now?

[damithc]

From dam...@gmail.com on March 21, 2014 05:32:12

Try to finish this issue soon. It is better if you have delivered the issue before GSoC selection begins.

[damithc]

From KaranKam...@gmail.com on March 21, 2014 07:17:41

Changes made. Link: https://codereview.appspot.com/72980044/#ps70001

Status: ReadyForReview

[damithc]

From jamesdju...@gmail.com on March 23, 2014 05:11:33

This issue was updated by revision 95afe5fe9545 .

Status: Delivered

[damithc]

From dam...@gmail.com on March 29, 2014 03:03:27

Status: Deployed
Labels: Milestone-V4.94