adminAccountManagementPage: Give more details in the alert shown when deleting an account

[damithc]

From dam...@gmail.com on March 06, 2014 18:09:29

For more safety, the alert can mention which account is being deleted.

Original issue: http://code.google.com/p/teammatespes/issues/detail?id=1687

[damithc]

From dam...@gmail.com on March 08, 2014 17:41:50

Junchao, give this one a try.

Owner: franklin...@gmail.com
Cc: arnold.k...@gmail.com
Labels: Reviewer-Arnold

[damithc]

From franklin...@gmail.com on March 08, 2014 21:53:16

Done without UI testing

[damithc]

From franklin...@gmail.com on March 08, 2014 22:57:28

Issue 1687 is fixed, pls verify at https://code.google.com/p/gujunchao-teammates/ Thanks(the uitest for this is not done--that means no test is done for this fixing yet. I have submitted another issue regarding lack uitest for admin page.)

Gu Junchao Major in Computer Engineering, National University of Singapore Primary Email: franklingujunchao@gmail.com franklingujunchao@gmail.com NUS Email: A0105750@nus.edu.sg A0105750@nus.edu.sg

[damithc]

From arnold.k...@gmail.com on March 09, 2014 19:21:52

Hi Junchao, please follow the "Process" section in the Developer Manual (DevMan) and upload your changes to the code review site. Do change the status of the issue accordingly too :)

[damithc]

From franklin...@gmail.com on March 09, 2014 21:33:58

Okay. Sorry for this.

[damithc]

From franklin...@gmail.com on March 10, 2014 00:13:48

Status: Started

[damithc]

From franklin...@gmail.com on March 10, 2014 01:15:14

Status: ReadyForReview

[damithc]

From arnold.k...@gmail.com on March 10, 2014 01:16:25

Don't forget the code review link :P

Status: ChangesRequested

[damithc]

From franklin...@gmail.com on March 10, 2014 01:29:24

what information is needed? can you suggest some?

[damithc]

From arnold.k...@gmail.com on March 10, 2014 01:36:44

Go to the Fixing Issues section here: http://teammatesv4.appspot.com/dev/devman.html#process and follow it step-bystep to the letter. Pay special attention to points 4 to 8.

[damithc]

From franklin...@gmail.com on March 10, 2014 01:43:44

https://codereview.appspot.com/73430043/ (sorry that I am a bit confused about the comment in issue tracker and the issue number in codereview. took me a long time to get what you are referring to)

[damithc]

From franklin...@gmail.com on March 10, 2014 01:48:22

https://codereview.appspot.com/73440043/ update of code

[damithc]

From arnold.k...@gmail.com on March 10, 2014 01:53:00

Sure no problem :)

Added comments at the review site.

Don't forget to change the status back after you've made the changes ;)

[damithc]

From arnold.k...@gmail.com on March 10, 2014 01:54:49

Do use the -i flag when you're reuploading patches so I can see the diffs against the old patch (see DevMan linked above for detail)

[damithc]

From franklin...@gmail.com on March 10, 2014 01:56:15

https://codereview.appspot.com/73450043/ update

[damithc]

From franklin...@gmail.com on March 10, 2014 01:59:41

Ok. got it.

Gu Junchao Major in Computer Engineering, National University of Singapore Primary Email: franklingujunchao@gmail.com franklingujunchao@gmail.com NUS Email: A0105750@nus.edu.sg A0105750@nus.edu.sg

[damithc]

From franklin...@gmail.com on March 10, 2014 02:07:42

https://codereview.appspot.com/73430043 should be updated by now

[damithc]

From franklin...@gmail.com on March 10, 2014 02:23:08

Status: ReadyForReview

[damithc]

From arnold.k...@gmail.com on March 10, 2014 19:19:27

Status: ChangesRequested

[damithc]

From franklin...@gmail.com on March 10, 2014 20:11:06

https://codereview.appspot.com/73430043

Status: ReadyForReview

[damithc]

From arnold.k...@gmail.com on March 10, 2014 20:20:54

This issue was updated by revision 32e566abc5a5 .

Status: Delivered

[damithc]

From arnold.k...@gmail.com on March 10, 2014 21:12:04

This issue was updated by revision c2dfa6174e9b .

Changed variable name to camelCase

[damithc]

From franklin...@gmail.com on March 10, 2014 22:01:52

update variable naming in js file https://codereview.appspot.com/73430043

[damithc]

From dam...@gmail.com on March 14, 2014 23:34:42

Status: Deployed
Labels: Milestone-V4.91