feedbackSubmitPage: NUMSCALE question does not disable when the session is closed

[damithc]

From arnold.k...@gmail.com on March 07, 2014 13:01:57

The input box is not disabled and the value can be changed even though the session is closed. It's not possible to submit as the submit button is disabled though.

Original issue: http://code.google.com/p/teammatespes/issues/detail?id=1689

[damithc]

From lwl1991 on March 13, 2014 20:06:43

Can i fix this? =)

[damithc]

From arnold.k...@gmail.com on March 13, 2014 20:48:39

Sure :P

Owner: lwl1991

[damithc]

From arnold.k...@gmail.com on March 13, 2014 20:49:02

Labels: Reviewer-Arnold

[damithc]

From lwl1991 on March 13, 2014 22:59:33

https://codereview.appspot.com/75580044/ Checked dev green for tests

Also, I found a bug related to Issue 1563 , where badly formatted numbers are accepted (firefox 12) such as "1.1.1" or "1.-3" and although the system does not record it, it says that "All responses submitted succesfully!"

Status: ReadyForReview

[damithc]

From arnold.k...@gmail.com on March 13, 2014 23:03:54

Ah, I think I decided to ignore that when saving but forgot to feedback to the user. Feel like doing another issue? :P

[damithc]

From arnold.k...@gmail.com on March 13, 2014 23:12:49

The form where there's no existing response yet also needs to be updated :P (currently the input box will disable if there's a response already but won't otherwise)

Status: ChangesRequested

[damithc]

From arnold.k...@gmail.com on March 13, 2014 23:13:59

Also, can you add a test for this? In the closed content page UI test all question type should be covered to check if everything is disabled.

[damithc]

From lwl1991 on March 14, 2014 03:24:28

https://codereview.appspot.com/75580044/ Added the tests and fixed the issue on no existing responses. I can try the other issue but might take some time =P

Status: ReadyForReview

[damithc]

From arnold.k...@gmail.com on March 14, 2014 05:53:24

It's probably good to add the test for the instructor side too :P

Status: ChangesRequested

[damithc]

From lwl1991 on March 14, 2014 06:07:11

Hmm I thought they all use the same *QuestionDetails so it would be unnecessary. Okay will add it in too.

[damithc]

From arnold.k...@gmail.com on March 14, 2014 06:15:06

They used to be completely separate, that's why the double test. I was considering scrapping one of the test before but it's kinda safer to just test both :S

[damithc]

From lwl1991 on March 15, 2014 07:32:59

Added tests for instructor side! https://codereview.appspot.com/75580044/

Status: ReadyForReview

[damithc]

From arnold.k...@gmail.com on March 16, 2014 21:56:21

This issue was updated by revision f70e61734106 .

Status: Delivered

[damithc]

From dam...@gmail.com on March 20, 2014 04:59:55

Status: Deployed
Labels: Milestone-V4.92