nus-oss-test / testrepo4

TEAMMATES system is online at
http://teammatesv4.appspot.com
0 stars 0 forks source link

InstructorEvalsPageUiTest fails #1753

Closed damithc closed 10 years ago

damithc commented 10 years ago

From dam...@gmail.com on March 12, 2014 11:20:55

Fails at the line 191 evalsPage.sortByName().verifyHtml("/instructorEvalAddSuccess.html");

Could be due to a date in the test data.

Original issue: http://code.google.com/p/teammatespes/issues/detail?id=1710

damithc commented 10 years ago

From dam...@gmail.com on March 11, 2014 20:21:51

Arnold, may be better to fix this soon because new contributors could be thrown off by this.

Owner: arnold.k...@gmail.com

damithc commented 10 years ago

From arnold.k...@gmail.com on March 11, 2014 20:23:58

Yeah, I also keep failing here due to an unexpected . Will try to see if verifyHtmlAjax is more appropriate.

damithc commented 10 years ago

From arnold.k...@gmail.com on March 11, 2014 20:54:02

https://codereview.appspot.com/74400043/ The test fails because the response rate was still loading when the html is checked. Changing the check to verifyHtmlAjax fixes this.

Status: ReadyForReview

damithc commented 10 years ago

From dam...@gmail.com on March 11, 2014 21:02:38

Actually, the problem went away after fixing Issue 1709 (it was a performance issue). Still, good to apply this patch.

Status: ReadyToMerge

damithc commented 10 years ago

From Gigi...@gmail.com on March 11, 2014 21:04:42

the root cause is Issue 1709 , revisions before revision fbc963acec7d have no such issue. revision fbc963acec7d makes page loading very slow (eg 400ms -> 4s), thus the response rate was still loading and causes verifyHtml to fail

damithc commented 10 years ago

From arnold.k...@gmail.com on March 11, 2014 22:47:01

This issue was updated by revision 54688836564e .

Status: Delivered

damithc commented 10 years ago

From dam...@gmail.com on March 14, 2014 23:34:42

Status: Deployed
Labels: Milestone-V4.91