search

nus-oss-test / testrepo4

TEAMMATES system is online at
http://teammatesv4.appspot.com
0 stars 0 forks source link

studentFeedbackResult: Inform student whether or not they have something new to see #1757

Closed damithc closed 10 years ago

damithc commented 10 years ago

From arnold.k...@gmail.com on March 14, 2014 12:21:40

When the page load a status message should be shown to inform them if they have something new to see.

Original issue: http://code.google.com/p/teammatespes/issues/detail?id=1717

damithc commented 10 years ago

From arnold.k...@gmail.com on March 13, 2014 22:16:32

Status: Started

damithc commented 10 years ago

From arnold.k...@gmail.com on March 13, 2014 22:49:33

What message should I give when there's nothing to see? Should I give a message when there is something to see too?

Cc: dam...@gmail.com

Attachment: Untitled picture.png

damithc commented 10 years ago

From dam...@gmail.com on March 13, 2014 23:09:54

That one looks good. Yes, can give a similar message when there is something to see.

damithc commented 10 years ago

From arnold.k...@gmail.com on March 13, 2014 23:20:42

"You have received new feedbacks and may see them below."?

damithc commented 10 years ago

From dam...@gmail.com on March 13, 2014 23:36:08

"You have received feedback from others. Please see below."

damithc commented 10 years ago

From arnold.k...@gmail.com on March 14, 2014 00:02:55

https://codereview.appspot.com/75890043/ I'm not sure but maybe the isStudentHasSomethingNewToSee method should be placed in one of the logic classes? FeedbackSessionLogic maybe?

Status: ReadyForReview

damithc commented 10 years ago

From dam...@gmail.com on March 14, 2014 00:08:49

Status: ReadyToMerge

damithc commented 10 years ago

From arnold.k...@gmail.com on March 14, 2014 05:50:51

This issue was updated by revision f65e148a2b57 .

Status: Delivered

damithc commented 10 years ago

From arnold.k...@gmail.com on March 15, 2014 01:41:17

Status: Deployed
Labels: Milestone-V4.91

damithc commented 10 years ago

From dam...@gmail.com on March 15, 2014 01:48:11

This was not included. I deployed before this was delivered. It will be in the next release.

Status: Delivered
Cc: -dam...@gmail.com
Labels: -Milestone-V4.91 Milestone-V4.92

damithc commented 10 years ago

From arnold.k...@gmail.com on March 15, 2014 01:53:01

Oh, ok, the commit log seems to show it before the tag merge, haha

damithc commented 10 years ago

From dam...@gmail.com on March 15, 2014 02:11:36

Yes, the tag was merged later. But the tag was applied to an earlier commit. :-) The release version is the one that got merged to (not from) the release branch.

damithc commented 10 years ago

From dam...@gmail.com on March 20, 2014 04:59:55

Status: Deployed