Closed damithc closed 10 years ago
From Gigi...@gmail.com on March 14, 2014 04:44:28
my quick fix, code review: https://codereview.appspot.com/75830044/
From dam...@gmail.com on March 14, 2014 05:15:58
kai, please add test cases as well.
Status: Accepted
Owner: Gigi...@gmail.com
Cc: jamesdju...@gmail.com
Labels: Reviewer-James
From arnold.k...@gmail.com on March 14, 2014 05:56:01
This is also true for sudent home page, by the way. Not supposed to happen but due to a bug if you are both an instructor and a student you can see your own private session in the student home page and the same error as above will happen.
The error doesn't happen in mashup/teammates.test's account because the json for mashup is wrong though
From Gigi...@gmail.com on March 14, 2014 06:28:52
@arnold.koroa seems that studentHomePage doesnt have this bug :p
cos in StudentHomePageAction, it's sortFeedbackSessionsByCreationTime, no touching on end time, then it's ok
From Gigi...@gmail.com on March 14, 2014 06:32:11
ops, sorry
it can happen, if feedback ID and createdTime r the same, then endTime will be used to compare and throw an error
From Gigi...@gmail.com on March 14, 2014 07:05:12
code review: https://codereview.appspot.com/75830044/
Status: ReadyForReview
From jamesdju...@gmail.com on March 16, 2014 01:31:53
This issue was updated by revision 5d9b80529b34 .
Status: Delivered
From dam...@gmail.com on March 20, 2014 04:59:55
Status: Deployed
Labels: Milestone-V4.92
From Gigi...@gmail.com on March 14, 2014 19:14:30
What steps will reproduce the problem? 1. Log in as Instructor, create a new course and enroll some students
Root cause:
Original issue: http://code.google.com/p/teammatespes/issues/detail?id=1720