search

nus-oss-test / testrepo4

TEAMMATES system is online at
http://teammatesv4.appspot.com
0 stars 0 forks source link

instructorFeedbackSessionAddComment: use AJAX to save comment #1760

Closed damithc closed 10 years ago

damithc commented 10 years ago

From dam...@gmail.com on March 16, 2014 17:49:13

Reloading the whole page is expensive. Auto-scrolling to the top is inconvenient.

Original issue: http://code.google.com/p/teammatespes/issues/detail?id=1724

damithc commented 10 years ago

From arnold.k...@gmail.com on March 16, 2014 21:32:09

Status: Started
Owner: arnold.k...@gmail.com

damithc commented 10 years ago

From arnold.k...@gmail.com on March 17, 2014 21:13:41

https://codereview.appspot.com/77190044/ There is a few weakness of this at the moment: 1) It's not possible to edit/delete a comment that is just added. A refresh is necessary. 2) The comment shown after adding is what the user submitted, not the one saved in the datastore. Should change this to the one from the datastore to enable editing but I'm worried about eventual consistency issues. 3) There are some HTML in the javascript to show the added comment. The amount of html will increase when we want to add edit/delete and can become messy. Maybe move the html generation to the PageData and do templating?

Status: ReadyForReview
Cc: dam...@gmail.com

damithc commented 10 years ago

From dam...@gmail.com on March 17, 2014 21:44:09

Need to add editing capability as well. Can do as a separate issue. Perhaps when the user click 'edit' you can retrieve the data from the server using another ajax request?

Status: ReadyToMerge

damithc commented 10 years ago

From arnold.k...@gmail.com on March 17, 2014 22:08:26

This issue was updated by revision 9b7f07ac0925 .

Status: Delivered

damithc commented 10 years ago

From dam...@gmail.com on March 20, 2014 04:59:55

Status: Deployed
Labels: Milestone-V4.92