Closed damithc closed 10 years ago
From shrianu...@gmail.com on March 18, 2014 23:17:01
How about the snap-shots here. The first picture is WITHOUT the change. The second is just an edited image, not the actual changed output. The CHANGE will be click-able, to open the default Mailer (ex : outlook), using MAILTO as suggested.
Status: Started
Attachment: one.png two.png
From dam...@gmail.com on March 18, 2014 23:23:28
Too noticeable :-p It should be almost unnoticeable unless the users is looking for it. e.g. small letters, not bold.
From shrianu...@gmail.com on March 18, 2014 23:25:20
yes the font can be adjusted according to requirements, but is the place for putting the information correct?
From dam...@gmail.com on March 18, 2014 23:50:27
I can't think of a better place for it. So, yes :-)
From shrianu...@gmail.com on March 19, 2014 03:18:08
Please review : http://codereview.appspot.com/77770043
Status: ReadyForReview
From arnold.k...@gmail.com on March 19, 2014 22:49:48
added comments at review site
Status: ChangesRequested
Owner: shrianu...@gmail.com
Labels: Reviewer-Arnold
From shrianu...@gmail.com on March 21, 2014 08:15:46
http://codereview.appspot.com/77770043
Status: ReadyForReview
From arnold.k...@gmail.com on March 22, 2014 23:25:03
Added comments at review site.
Upload a screenshot to show the link looks like?
Also, can you merge recent changes to your trunk before reuploading? The trunk had changed and I can't apply your patch.
Status: ChangesRequested
From shrianu...@gmail.com on March 25, 2014 06:28:57
http://codereview.appspot.com/79760043
Status: ReadyForReview
Cc: dam...@gmail.com
Attachment: one.png two.png
From dam...@gmail.com on March 25, 2014 07:23:41
Color not good (never use red with blue :-p). White is better.
From shrianu...@gmail.com on March 25, 2014 08:27:02
http://codereview.appspot.com/79760043 ,
Color changed :) to white!
From arnold.k...@gmail.com on March 26, 2014 02:40:52
Don't forget to update the test too, it still uses id="LINK" :)
and while you are at it maybe it's better if the '[' and ']' are the same size as the mailto link?
Status: ChangesRequested
From shrianu...@gmail.com on March 28, 2014 22:59:42
Please review : https://codereview.appspot.com/79760043
Status: ReadyForReview
From dam...@gmail.com on March 30, 2014 06:39:23
Arnold is going to be unavailable for a few days. Let's wait to see if he can review this sometime in the next few days.
From anubhav...@gmail.com on March 30, 2014 08:58:16
Sure sir :-)
From dam...@gmail.com on March 31, 2014 23:02:11
This test case is failing: InstructorFeedbackResultsPageUiTest
Status: ChangesRequested
From shrianu...@gmail.com on April 03, 2014 04:07:05
Sorry for the late reply . Please review https://codereview.appspot.com/77770043/
Status: ReadyForReview
From arnold.k...@gmail.com on April 03, 2014 04:12:55
Sorry, can you merge and reupload? I can't apply your patch due to conflicts
From arnold.k...@gmail.com on April 03, 2014 04:13:11
Status: ChangesRequested
From shrianu...@gmail.com on April 03, 2014 04:19:00
I says NO CHAGES FOUND. What should I do now?
From arnold.k...@gmail.com on April 03, 2014 04:21:09
That's odd, let me try again
From arnold.k...@gmail.com on April 03, 2014 04:23:08
LEt's see, did you upload using the -i flag? The previous link https://codereview.appspot.com/77770043/ only have two patches and the latest one is the one I commented on
From arnold.k...@gmail.com on April 03, 2014 04:23:46
oh wait, there's another link ( https://codereview.appspot.com/79760043 ) let me try again
Status: ReadyForReview
From arnold.k...@gmail.com on April 03, 2014 06:09:13
Somehow the UI tests still fails? I'm attaching the test report to this comment.
Prof, do you mind double checking this?
Attachment: emailable-report.html
From dam...@gmail.com on April 03, 2014 06:54:45
OK, i'll check. Most likely during the weekend.
From dam...@gmail.com on April 04, 2014 04:36:20
Yes, that test case is still failing. For example, Expected: From: Benny Charles (Team 1) [CFResultsUiT.benny.c@gmail.com]
Actual: From: Benny Charles (Team 1) [CFResultsUiT.charlie.d@gmail.com]
Status: ChangesRequested
From dam...@gmail.com on April 07, 2014 05:10:04
Arnold any idea why this is failing? Anubhav says he gets dev green on his computer.
Cc: -dam...@gmail.com arnold.k...@gmail.com
From arnold.k...@gmail.com on April 09, 2014 01:53:57
I'll try to figure it out. But I might only be able to do it on Friday.
From dam...@gmail.com on April 09, 2014 03:07:07
Added some comments.
From shrianu...@gmail.com on April 11, 2014 19:39:25
Please review : ( https://codereview.appspot.com/79760043 )
Status: ReadyForReview
From dam...@gmail.com on April 11, 2014 19:56:38
Added some comments. May be Arnold can say more.
From dam...@gmail.com on April 11, 2014 22:44:32
This issue was updated by revision 6dcc7061fc41 .
Status: Delivered
From dam...@gmail.com on April 11, 2014 22:46:38
Status: Deployed
Labels: Milestone-V4.96
From dam...@gmail.com on April 17, 2014 20:35:43
Status: Deployed
Cc: -arnold.k...@gmail.com
From dam...@gmail.com on March 16, 2014 18:01:36
It may be useful to show the email in some non obtrusive way. Sometimes the instructor may want to contact the student outside the system. A mailto link?
Original issue: http://code.google.com/p/teammatespes/issues/detail?id=1725