search

nus-oss-test / testrepo4

TEAMMATES system is online at
http://teammatesv4.appspot.com
0 stars 0 forks source link

InstructorStudentList: Filtering of students don't work correctly when there are archived courses #1770

Closed damithc closed 10 years ago

damithc commented 10 years ago

From dam...@gmail.com on March 22, 2014 19:51:17

Need to update both code and tests.

Original issue: http://code.google.com/p/teammatespes/issues/detail?id=1745

damithc commented 10 years ago

From dam...@gmail.com on March 22, 2014 04:51:51

Kai, can you have a look at this?

Owner: Gigi...@gmail.com
Cc: jamesdju...@gmail.com
Labels: Reviewer-James

damithc commented 10 years ago

From dam...@gmail.com on March 22, 2014 05:07:24

Seems to work if 'display archived courses' is selected but doesn't work if the option is not selected and some archived courses exist.

damithc commented 10 years ago

From Gigi...@gmail.com on March 22, 2014 05:09:26

noted

Status: Started

damithc commented 10 years ago

From Gigi...@gmail.com on March 22, 2014 05:26:40

Hi sir,

Is that you want to search students in the archived courses?

The current search method is based on javascript, so it can only filter the courses displayed.. So when 'display archived courses' is selected, then archived courses are displayed and thus they can be filtered.

But the archived courses and teams displayed in 'show more options' are misleading, So I will make a patch to hide those archived courses and teams in 'show more options' , is that fine for this issue?

damithc commented 10 years ago

From dam...@gmail.com on March 22, 2014 05:45:37

No, that's not the problem.
The displayed results are wrong. e.g. I tick only course X and the results show course Y. The list of emails shown is wrong too. See attached image. Only one student is shown in the page, but 5 emails are displayed.

Attachment: filter wrong.png

damithc commented 10 years ago

From Gigi...@gmail.com on March 22, 2014 06:15:35

Yes. Those 5 emails are from archived courses.

The email filter based on javascript need information from those displayed courses. It will not work for archived courses when archived courses are hidden.

damithc commented 10 years ago

From Gigi...@gmail.com on March 22, 2014 06:27:19

'I tick only course X and the results show course Y.':

this one is caused by: The checkbox's index normally should pair with course's index. When it's ticked, paired course will be filtered. When there are archived courses hidden, the indices of courses will change. But checkboxs' indices remain the same. Thus, the wrong course is filtered

damithc commented 10 years ago

From dam...@gmail.com on March 22, 2014 07:13:22

Can fix?

damithc commented 10 years ago

From Gigi...@gmail.com on March 22, 2014 07:23:03

Sure :)

damithc commented 10 years ago

From Gigi...@gmail.com on March 22, 2014 08:41:40

Code review: https://codereview.appspot.com/77050047/

Status: ReadyForReview

damithc commented 10 years ago

From jamesdju...@gmail.com on March 23, 2014 05:18:27

This issue was updated by revision ac18907dcc19 .

Status: Delivered

damithc commented 10 years ago

From dam...@gmail.com on March 29, 2014 03:03:27

Status: Deployed
Labels: Milestone-V4.94