search

nus-oss-test / testrepo4

TEAMMATES system is online at
http://teammatesv4.appspot.com
0 stars 0 forks source link

evalsPageUiTest starting time is fixed #1776

Closed damithc closed 10 years ago

damithc commented 10 years ago

From franklin...@gmail.com on April 02, 2014 01:20:59

What steps will reproduce the problem? 1. run the test after 01/04/2014 What is the expected output? What do you see instead? the test:testAddAction fails

Original issue: http://code.google.com/p/teammatespes/issues/detail?id=1767

damithc commented 10 years ago

From Gigi...@gmail.com on April 01, 2014 11:48:09

haha,

"the start time should be in the future", but the test data for start time is 01/04/2014

damithc commented 10 years ago

From dam...@gmail.com on April 01, 2014 17:44:28

Junchao, can you fix it? Just changing the date to a future time (2016?) is enough.

Status: Accepted
Owner: franklin...@gmail.com
Labels: -Priority-Medium Priority-High

damithc commented 10 years ago

From franklin...@gmail.com on April 01, 2014 17:48:33

OK. working on it.

Status: Started
Cc: dam...@gmail.com

damithc commented 10 years ago

From franklin...@gmail.com on April 01, 2014 18:31:33

https://codereview.appspot.com/83360044/ (All tests passed)

Status: ReadyForReview

damithc commented 10 years ago

From dam...@gmail.com on April 01, 2014 20:17:33

This doesn't break any tests?

Status: ChangesRequested

damithc commented 10 years ago

From franklin...@gmail.com on April 01, 2014 20:28:23

It just passed on my machine. No kidding

damithc commented 10 years ago

From dam...@gmail.com on April 01, 2014 20:47:14

James, for merging please.

Status: ReadyToMerge
Cc: -dam...@gmail.com jamesdju...@gmail.com
Labels: Difficulty-Low

damithc commented 10 years ago

From jamesdju...@gmail.com on April 02, 2014 01:48:35

This issue was updated by revision e96aa9396d90 .

Status: Delivered

damithc commented 10 years ago

From dam...@gmail.com on April 05, 2014 20:40:21

Status: Deployed
Labels: Milestone-V4.95