search

nus-oss-test / testrepo4

TEAMMATES system is online at
http://teammatesv4.appspot.com
0 stars 0 forks source link

instructorEvalEdit: cannot edit evaluations in Chrome #1783

Closed damithc closed 10 years ago

damithc commented 10 years ago

From dam...@gmail.com on April 15, 2014 15:53:33

It simply says "Please fill in all the relevant fields." in chrome, but works in Firefox and IE.

Original issue: http://code.google.com/p/teammatespes/issues/detail?id=1782

damithc commented 10 years ago

From Gigi...@gmail.com on April 15, 2014 03:17:46

Cause: in instructorEvalEditPage, and inside form with name "form_addevaluation",

There are 2 elements with the same name: a select element and an input element both have name "timezone".

Thus in instructorEvals.js, inside function checkEditEvaluation(form), selector "form.timezone" cannot get the exact timezone (since there are 2), and produce the error.

In Safari or Firefox, "form.timezone" produces UNDEFINED, and can pass validation in instructorEvals.js, which is UNDEFINED != "". In Chrome, it produces "", and then cannot pass the validation.

damithc commented 10 years ago

From Gigi...@gmail.com on April 15, 2014 03:26:54

patch is produced, trying to make dev green

damithc commented 10 years ago

From franklin...@gmail.com on April 15, 2014 03:57:07

i noticed id is the same for feedback too. because I was doing js validation for eval and feedback. i think anyway two elements with the same id is not a good idea.

damithc commented 10 years ago

From Gigi...@gmail.com on April 15, 2014 03:59:09

codereview: https://codereview.appspot.com/87780045/

damithc commented 10 years ago

From franklin...@gmail.com on April 15, 2014 04:01:09

Kai, feedbackeditpage has the same issue

damithc commented 10 years ago

From Gigi...@gmail.com on April 15, 2014 04:02:45

@franklingujunchao just checked, there is no such issue in instructorFeedbackEditPage

damithc commented 10 years ago

From franklin...@gmail.com on April 15, 2014 04:05:04

sorry. I am wrong about this. but I did remember some place the timezone id is used twice.

damithc commented 10 years ago

From dam...@gmail.com on April 15, 2014 07:19:44

I'll release this as a hot patch ASAP

Status: MergeInProgress
Owner: Gigi...@gmail.com
Labels: Difficulty-Medium

damithc commented 10 years ago

From dam...@gmail.com on April 15, 2014 07:42:58

This issue was updated by revision f75576935b62 .

Status: Delivered

damithc commented 10 years ago

From dam...@gmail.com on April 15, 2014 20:49:24

Status: Deployed
Labels: Milestone-V4.96.01