search

nus-oss-test / testrepo4

TEAMMATES system is online at
http://teammatesv4.appspot.com
0 stars 0 forks source link

instructorStudentList: show total students #205

Open damithc opened 10 years ago

damithc commented 10 years ago

From dam...@gmail.com on December 20, 2013 09:34:38

Showing total students (and may be other statistics such as course count) can be useful

Original issue: http://code.google.com/p/teammatespes/issues/detail?id=1361

damithc commented 10 years ago

From dam...@gmail.com on March 05, 2014 23:56:04

Labels: -Priority-Low Priority-Medium SuitableAsFirstIssue

damithc commented 10 years ago

From dam...@gmail.com on March 19, 2014 04:39:31

Qiao Wei, give this a try.

Owner: qiaowe...@gmail.com
Cc: jamesdju...@gmail.com
Labels: Reviewer-James

damithc commented 10 years ago

From qiaowe...@gmail.com on March 19, 2014 17:59:19

Hi Dr. Damith, just want to be clear, do you mean showing the number of total students on the home page?

damithc commented 10 years ago

From dam...@gmail.com on March 19, 2014 18:19:18

No, in the 'students' tab. In fact, it can be the total shown in the current page. e.g. "Currently showing: 136 students"

damithc commented 10 years ago

From qiaowe...@gmail.com on March 21, 2014 01:11:07

Hi Dr.Damith, I have added in showing total student number in the instructorStudentList page(see in the attachment). Is that what you mean? Thanks.

Attachment: instructorStudentList.png

damithc commented 10 years ago

From dam...@gmail.com on March 21, 2014 03:22:39

Yes, something like that Qiao Wei. May be below the light blue box, in smaller letters?

damithc commented 10 years ago

From dam...@gmail.com on March 21, 2014 05:32:12

Try to finish this issue soon. It is better if you have delivered the issue before GSoC selection begins.

damithc commented 10 years ago

From qiaowe...@gmail.com on March 22, 2014 19:22:42

https://codereview.appspot.com/78720044/ Hi prof, here is the code for review.

Status: ReadyForReview

damithc commented 10 years ago

From dam...@gmail.com on March 22, 2014 19:42:49

Got dev green?

Status: ChangesRequested

damithc commented 10 years ago

From qiaowe...@gmail.com on March 26, 2014 03:15:30

Hi prof, I am sorry for doing it so late. I have tried to change some test cases. However, there is still one test that cannot pass. That test case seems not related to the part I have changed. Can you give me some hint?

damithc commented 10 years ago

From jamesdju...@gmail.com on March 26, 2014 03:23:56

Which test case is it?

damithc commented 10 years ago

From qiaowe...@gmail.com on March 26, 2014 06:32:55

testInstructorCourseEnrollPage

damithc commented 10 years ago

From dam...@gmail.com on March 26, 2014 07:29:46

You can ignore that one. Go ahead and submit the revised patch.

damithc commented 10 years ago

From qiaowe...@gmail.com on March 26, 2014 17:38:43

Hi prof, I have submitted it to the code review system. https://codereview.appspot.com/80550043/

damithc commented 10 years ago

From dam...@gmail.com on March 26, 2014 18:20:44

James will review this Qiao Wei, after you have changed the issue status appropriately. James, is there a more efficient way to get this number, perhaps, from and existing data structure? Having one more loop is going to make the page even slower.

damithc commented 10 years ago

From qiaowe...@gmail.com on April 06, 2014 04:06:48

Status: ReadyForReview

damithc commented 10 years ago

From jamesdju...@gmail.com on April 08, 2014 20:00:20

Hi, I've made a comment on your patch

Status: ChangesRequested