Add intro to mashup.jsp

[damithc]

From dam...@gmail.com on March 23, 2014 08:55:31

The page in concern is /dev/mashup.jsp

Add this at the top:

"This page contains a combination of all pages of the TEAMMATES app. It is used for manually inspecting the TEAMMATES UI for visual defects. To load this page, you need to run the test MashupPageUiTest.java."

Original issue: http://code.google.com/p/teammatespes/issues/detail?id=1746

[damithc]

From RadulescuAlin93 on March 23, 2014 05:00:16

Hello! I've a question for this: Should I add the line at the top of the page like in the picture I've attached, or should I just add a commented line at the top of the mashup.jsp file?

Attachment: mashup.png

[damithc]

From dam...@gmail.com on March 23, 2014 05:11:16

Alin, Having it in the page (as in the screenshot) is better. May be align a bit better?

[damithc]

From RadulescuAlin93 on March 23, 2014 05:34:55

What do you mean by better aligning, more to the left, more to the right, in the middle, to the right margin?

I've also added a dotted underline and a mouseover tip on "MashupPageUiTest.java" indicating it's location in the project, so whoever needs to run the test doesn't have to browse trough the test folders, as I did*.

*though the test folders have suggestive names, new guys will have trouble with them anyways.

[damithc]

From RadulescuAlin93 on March 23, 2014 05:53:56

Is this place any better?

Attachment: mashup.png

[damithc]

From dam...@gmail.com on March 23, 2014 06:03:10

Perhaps, add a title "Mashup Page" at the top (center?), followed by the new intro, and have the "Table of Contents" in smaller letters? By the way, the link to the file is a nice touch. Definitely useful.

[damithc]

From RadulescuAlin93 on March 23, 2014 06:43:22

I'm sorry for my late answering. I had my head busy with some homework, I'll try to refresh the page more often. Here's how it looks with the new changes.

Attachment: mashup.png

[damithc]

From dam...@gmail.com on March 23, 2014 07:09:24

'Table of contents' should be below the intro. Otherwise it doesn't make sense. Intro can be centered.

[damithc]

From RadulescuAlin93 on March 23, 2014 07:14:05

I had thought about that myself, but I didn't move it since you only asked me to make it smaller. I'll gladly change it now.

[damithc]

From RadulescuAlin93 on March 23, 2014 07:34:45

My masterpiece is done. I've moved everything in the table body, to make it more pro-ish.

Attachment: mashup.png

[damithc]

From dam...@gmail.com on March 23, 2014 07:39:45

Nice. Upload the patch for review. :-)

[damithc]

From RadulescuAlin93 on March 23, 2014 07:41:02

I'm sorry it takes me a lot to make such simple changes. I've only got very little html experience, and I never used CSS before. I hope I'll be quicker when it comes to programming in Java.

[damithc]

From RadulescuAlin93 on March 23, 2014 07:42:33

How do I upload it for review? Should I just push it to my clone ?

[damithc]

From RadulescuAlin93 on March 23, 2014 07:46:12

If so, here it is: https://code.google.com/r/radulescualin93-gsocteammates/source/browse/src/main/webapp/dev/mashup.jsp

[damithc]

From dam...@gmail.com on March 23, 2014 07:48:49

That's not how you upload patches. Please refer devman for the procedure :-)

[damithc]

From RadulescuAlin93 on March 23, 2014 09:09:37

I followed the steps in devman, everything went fine (eventually) I can't find my code here, though: https://codereview.appspot.com/search?owner=Alin+Radulescu

[damithc]

From RadulescuAlin93 on March 23, 2014 09:39:59

I have to meet a homework deadline for tonight. I can't look for solutions anymore. I would gladly accept any help regarding this problem. It's embarrassing that I needed one whole day to add a title to a page, I'll try to be quicker from now on.

Status: ReadyForReview

[damithc]

From RadulescuAlin93 on March 23, 2014 14:54:49

Any suggestions... ?

[damithc]

From dam...@gmail.com on March 23, 2014 16:48:32

Not to worry. These things take time, especially until you get used to the workflow. Resume when you are free again.

[damithc]

From RadulescuAlin93 on March 24, 2014 07:23:51

Trying to upload it for reviewing following the steps in devman EXACTLY as they are.

Status: Started

[damithc]

From RadulescuAlin93 on March 24, 2014 08:06:39

Could you give me a hand with the steps ? Though I executed the upload.py ... command successfully, nothing was uploaded to my code review page: https://codereview.appspot.com/search?owner=Alin+Radulescu ( My code looks commited in the photo )

Attachment: hg out.png

[damithc]

From dam...@gmail.com on March 24, 2014 08:09:04

What is the output when you run the upload.py command? Can you copy paste console output here?

[damithc]

From RadulescuAlin93 on March 24, 2014 08:11:49

Is this wrong usage?

Attachment: hg out.png

[damithc]

From dam...@gmail.com on March 24, 2014 08:26:16

upload.py is not in the same folder? Put it in the same folder and try again. does "hg diff --rev=default" produce some output?

[damithc]

From RadulescuAlin93 on March 24, 2014 08:40:04

Same output

Attachment: upload.png

[damithc]

From dam...@gmail.com on March 24, 2014 08:44:01

Looks like you are in the default branch. You should be in the branch you created for the issue. upload.py uploads the difference between the current branch and the default branch. If you are already in the default branch, there is nothing to upload.

[damithc]

From RadulescuAlin93 on March 24, 2014 09:05:19

I am now in the right branch. upload.py has no output diff --rev=default has lots of output

Attachment: upload.png

[damithc]

From dam...@gmail.com on March 24, 2014 09:08:05

rev=default, not ref=default :-p

[damithc]

From RadulescuAlin93 on March 24, 2014 09:23:44

That was dumb of me. Nothing changed.

[damithc]

From RadulescuAlin93 on March 24, 2014 09:35:40

2 hours in a row for such a minor issue... I will resume after midnight. I will try to delete my branch, my changes, make another clone if necessary... Until then: another homework :-P