search

nus-oss-test / testrepo4

TEAMMATES system is online at
http://teammatesv4.appspot.com
0 stars 0 forks source link

Student:EvalSumission -> separate self-evaluation from peer-evaluations #657

Closed damithc closed 10 years ago

damithc commented 10 years ago

From dam...@gmail.com on September 23, 2012 20:30:09

As per title. Perhaps we can also indicate that self-evaluation is not considered in contribution calculations.

Also rephrase: Self evaluation in Team [Team 2] -> Self evaluation

Original issue: http://code.google.com/p/teammatespes/issues/detail?id=336

damithc commented 10 years ago

From dam...@gmail.com on February 20, 2013 03:54:55

Labels: -Type-UI Type-Task Difficulty-Medium

damithc commented 10 years ago

From arnold.k...@gmail.com on December 09, 2013 19:42:14

By separate do you mean in a different page or the same page but in a separate box? Probably can give a white line in-between self-evaluation and peer-evaluation like how the box with course information is separated from the evaluation box.

Can I do this? I'll go through the Student evaluation slice too while I'm at it. (Also, I can probably do issue 1084 at the same time as it is very minor).

damithc commented 10 years ago

From dam...@gmail.com on December 09, 2013 20:48:21

In the same page. Yes, some visual separation is enough. Sure Arnold, you can do this. Try not to do multiple issues in the same patch. We should be able to undo fixes independently. Also, leave low priority low difficulty issues for beginners to do. We have a shortage of issues beginners can do.

Owner: arnold.k...@gmail.com

damithc commented 10 years ago

From arnold.k...@gmail.com on December 09, 2013 21:09:09

Alright, will work on this and leave issue 1084 as it is.

damithc commented 10 years ago

From arnold.k...@gmail.com on December 09, 2013 22:45:06

https://codereview.appspot.com/39890043/ 1) Separated self-evaluation from peer-evaluation with some blank lines 2) Rephrased Self evaluation in Team [Team 2] -> Self evaluation 3) Did not add the "self-evaluation is not considered in contribution calculations" due to difficulty in making sure the meaning is clear as discussed with Dr Damith 4) Updated affected UI Tests (Student Evaluation Submission forms and Instructor Evaluation Submission Edit forms)

Status: ReadyForReview

damithc commented 10 years ago

From dam...@gmail.com on December 09, 2013 23:57:56

This issue was updated by revision a175bd595bbf .

damithc commented 10 years ago

From dam...@gmail.com on December 09, 2013 23:58:09

Status: Delivered

damithc commented 10 years ago

From dam...@gmail.com on December 15, 2013 02:01:29

Status: Deployed
Labels: Milestone-V4.75

damithc commented 10 years ago

From dam...@gmail.com on February 26, 2014 01:56:50

This issue was updated by revision a175bd595bbf .