nus-oss-test / testrepo4

TEAMMATES system is online at
http://teammatesv4.appspot.com
0 stars 0 forks source link

Deprecate unscalable methods in DB layer #712

Closed damithc closed 10 years ago

damithc commented 10 years ago

From dam...@gmail.com on November 28, 2012 19:03:22

There are some unscalable getAll methods in the DB Layer. Some of these methods could be used by Admin side. However, deprecating them will reduce the risk of them being used unnecessarily.

Original issue: http://code.google.com/p/teammatespes/issues/detail?id=396

damithc commented 10 years ago

From dam...@gmail.com on January 25, 2013 02:55:37

Labels: -Priotiry-Low Priority-Low

damithc commented 10 years ago

From dam...@gmail.com on February 20, 2013 02:19:57

Labels: Difficulty-Low

damithc commented 10 years ago

From dam...@gmail.com on February 20, 2013 03:51:02

Issue 347 has been merged into this issue.

damithc commented 10 years ago

From tanweixi...@gmail.com on March 14, 2013 00:03:41

Hi Prof,

based on issue 347 , is it suppose use a

@Depricated tag on top of the following methods: getCoordinators getStudentEntities getStudents getCoordinatorEntities

Thanks

damithc commented 10 years ago

From dam...@gmail.com on March 14, 2013 07:48:43

Wei Xin, do you want to do this one too? Note that the method names may have changed in recent times. The ones we want to deprecate are the ones that return all entities of a type. They are not scalable because as the size of the database increases, the execution time of them will increase too.

damithc commented 10 years ago

From tanweixi...@gmail.com on March 14, 2013 17:01:36

So you means that we have to find all method that return a "" in the storage api?

damithc commented 10 years ago

From dam...@gmail.com on March 14, 2013 19:40:52

Returning a list is OK. Returning all entities is not. get all students in a class: OK (the class size will not increase as the user base grow) get all students in the system: not scalable

damithc commented 10 years ago

From dam...@gmail.com on January 13, 2014 02:39:35

Done at some point

Status: Duplicate