[Project A][MacSilicon][Kam Jia Yue] Upgrade to Java 17

nus-oss / AB3-J17

:ab::three: Address Book sample application (Level 3)

https://se-education.org/addressbook-level3

MIT License

0 stars 16 forks source link

[Project A][MacSilicon][Kam Jia Yue] Upgrade to Java 17 #16

Closed jyue487 closed 2 months ago

jyue487 commented 2 months ago

OS used: Mac Silicon JDK distribution used: Azul IDE used: IntelliJ Link to the uploaded JAR file: MacSilicon-KamJiaYue.jar Any other noteworthy info you want to share: NA

damithc commented 2 months ago

@jyue487 The changes in this PR is not enough to upgrade the Java version.

jyue487 commented 2 months ago

After changing the sourceCompatibility, targetCompatibility and switched to the correct FX Azul Zulu JDK, my previous changes is no longer needed, simply setting the two variables mentioned just now to JavaVersion.VERSION_17 would have made things worked perfectly.

damithc commented 2 months ago

Closing, as the migration was done in https://github.com/nus-oss/AB3-J17/commit/fe805d8553bbc329644371a6e732a8317ea6686f