search

nus-oss / AB3-J17

:ab::three: Address Book sample application (Level 3)
https://se-education.org/addressbook-level3
MIT License
0 stars 16 forks source link

Reverse Java-11 specific workaround in gradle.properties #18

Closed damithc closed 1 month ago

damithc commented 1 month ago

See if we can reverse this now ...

https://github.com/se-edu/addressbook-level3/commit/09837d98cc0443a75e7291e6aceb76764e18ca04

aureliony commented 1 month ago

I have tested reverting the TLS workaround, and encountered no issues with GH Actions. Both Java CI and Codecov are working as expected.

https://github.com/aureliony/AB3-J17/commit/549e670609793a8ef62b7a7cb6f0cfc11309c4ff

damithc commented 1 month ago

Thanks for checking @aureliony Go ahead and send a PR for this.