search

nus-oss / AB3-J17

:ab::three: Address Book sample application (Level 3)
https://se-education.org/addressbook-level3
MIT License
0 stars 16 forks source link

Revert TLS workaround after upgrading to JDK17 #19

Closed aureliony closed 1 month ago

aureliony commented 2 months ago

Closes #18

hjungwoo01 commented 2 months ago

I followed what was changed in this PR and after testing, I can confirm that everything works as expected. There were no issues with GitHub Actions, and both Java CI and Codecov are functioning correctly on my Mac Silicon.

baskargopinath commented 2 months ago

works on m2 macbook pro, sonoma 14.5. @damithc, im wondering if we should test on macOS sequoia beta which will be released in september. so if mid-semester if some students upgrade to it we might be better prepared

damithc commented 2 months ago

works on m2 macbook pro, sonoma 14.5. @damithc, im wondering if we should test on macOS sequoia beta which will be released in september. so if mid-semester if some students upgrade to it we might be better prepared

Yes @baskargopinath , in general, it's a good idea to test on upcoming version if feasible.

damithc commented 1 month ago

@aureliony Can you add a detailed commit message (subject + body) too?

Follow the guidelines given in https://se-education.org/guides/conventions/git.html