search

nus-oss / AB3-J17

:ab::three: Address Book sample application (Level 3)
https://se-education.org/addressbook-level3
MIT License
0 stars 16 forks source link

Update CI script to match newer versions of the tools used #26

Closed damithc closed 4 weeks ago

damithc commented 1 month ago

Investigate the need for the following changes to .github/workflows/gradle.yml in https://github.com/nus-oss/AB3-J17/pull/4/files (by @brein62), and if justified, send PRs to update each.

image

aureliony commented 1 month ago

There is no real need to bump the workflow versions as the current ones are still working fine, but it would be good to update to the latest versions to minimize the possibility of things breaking in the future.

brein62 commented 1 month ago

As of now the old versions of the workflow actions are currently working perfectly fine with GitHub Actions, but do generate several warnings regarding the use of old Node versions (within the GitHub actions) which I felt that might lead to possibly dropped support or unintended outcomes when GitHub CI actions are performed in the future.

With the changes reflected, the actions still work properly and there are no longer any warnings.

Thus, these changes are not strictly needed for now, but good to have for future-proofing CI workflows (at least for the next few batches of CS2103/T students).

IMG_6041

IMG_6042

damithc commented 1 month ago

Thanks for the inputs so far @brein62 @aureliony I'm leaning towards updating. So, feel free to send PRs for the required updates.