nus-oss / AB3-J17

:ab::three: Address Book sample application (Level 3)

https://se-education.org/addressbook-level3

MIT License

0 stars 16 forks source link

[Project A][Win11][macareonie] Upgrade to Java 17 #3

Closed macareonie closed 2 months ago

macareonie commented 2 months ago

Migrate to Java 17

Description

This PR migrates the project from Java 11 to Java 17, maintaining back compatibility with Java 11 and resolving warnings generated from code using versions below Java 11.

Details

OS used: Windows 11
JDK distribution used: Oracle OpenJDK version 17.0.11
IDE used: IntelliJ IDEA
Link to JAR file: Download here

Other info

The warnings from previous Java versions were resolved by implementing changes suggested by the IDE.

itstrueitstrueitsrealitsreal commented 2 months ago

Tested on Mac Silicon with JDK-FX 17.0.11.fx-zulu, and working.

Steps followed:

Downloaded the JAR file from the PR.
Switched to JDK-FX 17.0.11.fx-zulu using SDKMAN.
Ran the JAR file using java -jar Win11-macareonie.jar.
Performed a smoke test to verify basic functionality.

Results:

Everything is functioning as expected.

Screenshots:

jyue487 commented 2 months ago

Tested on Mac Silicon with JDK-FX 17.0.11.fx-zulu, and working.

Steps and results are identical to above.

teoks0199 commented 2 months ago

Tested on Windows 11, and working.

Steps followed:

Downloaded the JAR file from the PR.
Ran the JAR file using java -jar Win11-macareonie.jar.
Performed a smoke test to verify basic functionality.

bennyLCK commented 2 months ago

Smoke-Tested on Windows 11, using Oracle OpenJDK version 17.0.10 on Windows Powershell Terminal same as @teoks0199, basic commands were run to ensure full functionality of the application.

baskargopinath commented 2 months ago

Tested on Mac Silicon with JDK-FX 17.0.11.fx-zulu, and working.

Steps followed: Downloaded the JAR file from the PR. Switched to JDK-FX 17.0.11.fx-zulu Ran the JAR file using java -jar Win11-macareonie.jar. Performed a smoke test to verify basic functionality. Results: Everything is functioning as expected.

Screenshots:

aureliony commented 2 months ago

Tested on Ubuntu 22.04.4 LTS with zulu jdk 17.0.11. JAR is working fine.

Steps followed: Downloaded the JAR file from the release. Ran the JAR file using java -jar Win11-macareonie.jar. Performed a smoke test to check basic functionality.

Results: Everything is functioning as expected. Screenshot from 2024-07-06 19-37-14

gongg21 commented 2 months ago

Tested on MacSilicon with JDK-FX 17.0.11.fx-zulu, and working fine. Switched using SDKMAN, ensure it is 17.0.11.fx-zulu, note the .fx suffix. Add/Delete command tested, works. Help command tested, works. Ran JAR file using java -jar <filename>.

Carlintyj commented 2 months ago

Tested on Mac (Silicon) using JDK-FX 17.0.11.fx-zulu and working.

Downloaded the JAR release, ran the jar file using java -jar Win11-macareonie.jar Performed smoke test to check functionality.

jedkohjk commented 2 months ago

Tested on Windows 11 and working.

Steps I followed:

Downloaded the JAR file from the release.
Ran java -jar Win11-macareonie.jar.
Tested some basic commands.

Screenshot

damithc commented 2 months ago

Closing, as the migration was done in https://github.com/nus-oss/AB3-J17/commit/fe805d8553bbc329644371a6e732a8317ea6686f