[Project A][Win11][jedkohjk] Upgrade to Java 17

nus-oss / AB3-J17

:ab::three: Address Book sample application (Level 3)

https://se-education.org/addressbook-level3

MIT License

0 stars 16 forks source link

[Project A][Win11][jedkohjk] Upgrade to Java 17 #7

Closed jedkohjk closed 2 months ago

jedkohjk commented 2 months ago

OS: Windows 11 (asked a friend about Mac) JDK Distribution: Oracle Link to JAR file: https://github.com/jedkohjk/AB3-J17/releases/download/Milestone-1/addressbook.jar

damithc commented 2 months ago

We faced this ARM vs Intel issue even with Java 11 but eventually we figured using the prescribed Azul JDK removed the need for adding mac-aarch64 to the Gradle file. I'm hoping we can do something similar with Java 17. Can you try the JDK version suggestion in https://github.com/nus-oss/AB3-J17/pull/6 and report findings?

jedkohjk commented 2 months ago

Hi, I actually didn't have any issues with my Windows laptop. I made the changes after comparing with my friend who used mac (who is also doing this project). I will remove the additions of mac-aarch64 from my PR.

damithc commented 2 months ago

Closing, as the migration was done in https://github.com/nus-oss/AB3-J17/commit/fe805d8553bbc329644371a6e732a8317ea6686f