search

nus-oss / Git-Labels

Google Chrome Extension used to manage Git Labels
2 stars 4 forks source link

Make the panel slide-in faster #11

Open damithc opened 7 years ago

damithc commented 7 years ago

The extension is for users who want to do things fast. The slide-in speed of the panel is a bit too slow for such users. I find myself already typing label names while in the panel is still sliding-in, and sometimes it result in unexpected behavior.

jiajunGit commented 7 years ago

@damithc I have added a fix for this issue in commit 4de1946. Could you check to see if the input gains focus quick enough when the panel is sliding in? Thanks.

Besides the panel sliding out due to the input not gaining focus fast enough when typing, are there any other unexpected behaviors you have experienced due to this issue?

damithc commented 7 years ago

~~If I type L, wait for panel to appear, and type L again: p.Low is selected, as expected. If I type L and L without waiting, the panel aborts the slide-in halfway and slides out again.~~

damithc commented 7 years ago

Seems to be fixed. It seems I didn't update properly when I wrote the previous comment. 👍

damithc commented 7 years ago

The problem still persists if I type fast enough. e.g. If you type L and A fast enough, the labels panels slide in is aborted halfway and the assignees field in the page get activated instead.

jiajunGit commented 7 years ago

@damithc Could you check to see if this issue is resolved on your side? Thanks! (The fix should be in version 1.0.1)

damithc commented 7 years ago

Yes, seems so. First I have to wait till the panel icon appears, but after that even a very fast L A gets me the right label. The problem persists if I type L A before the panel icon appears, but that is unavoidable I guess.