search

nus-tic4002-AY2021S2 / pe-dev-response

0 stars 0 forks source link

Inconsistent Error message for delete command #91

Open nus-pe-bot opened 3 years ago

nus-pe-bot commented 3 years ago

Current behaviour and issue:

The error message for 3 index which are both invalid are different.

e.g. delete 0 e.g. delete 12 (when there is no employee with index 12) e.g. delete -1

image.png

image.png

image.png

[original: nus-tic4002-AY2021S2/pe-interim#91] [original labels: severity.Low type.FunctionalityBug]

wz-chan commented 3 years ago

Team's Response

As indicated in the UG, the index is defined to be a positive integer. The app treats "-1" and "0" the same way as other erroneous input such as "abc" and "xyz". This is consistent behaviour in our opinion.

Duplicate status (if any):

--