nus-tic4002-AY2021S2 / pe-dev-response

0 stars 0 forks source link

EDIT command allows user to update join date to a early date #92

Open nus-pe-bot opened 3 years ago

nus-pe-bot commented 3 years ago

Issue and current behaviour:

Join date can be updated to an early date using the e.g. edit 1 j/1900-01-01 When an employee join the employee end date should not be able to be updated to an earlier date to ensure employment data integrity.

Expected behaviour:

the join date of existing employee which already exists should not be allowed to be backdated. There should be a check for backdated updates.

image.png

Steps to replicate:

1) create an existing employee 2) use the LIST command to identify his index 3) back date his join date e.g. edit 1 j/1900-01-01


[original: nus-tic4002-AY2021S2/pe-interim#92] [original labels: severity.Medium type.FeatureFlaw]

wz-chan commented 3 years ago

Team's Response

Users should always be able to edit the join date because this is necessary, and also the simplest way, to correct a mistake during the data input. In addition, the target users are in small businesses; it is an overkill to implement any additional mechanism to detect, prevent or audit such human errors.

Changed severity to very low cause it doesn't affect operations.

Duplicate status (if any):

--