nus-vv-streams / vvtk

A toolkit for volumetric video research
MIT License
10 stars 8 forks source link

Remove debugging output #12

Closed weitsang closed 1 year ago

weitsang commented 1 year ago

When run with

vv  read ./in +output=plys     \
    write +input=plys          \
        --output-format pcd    \
        --storage-type binary  \
        --output-dir ./out

A verbose output is shown. The tool should not print any messages unless explicitly asked to (e.g., add a --verbose or --progress flag).

args: ["read", "./in", "+output=plys"]
args: ["write", "+input=plys", "--output-format", "pcd", "--storage-type", "binary", "--output-dir", "./out"]
progress_recvs.len(): 2
=======================
read: 0
write: 0
=======================
Writing point cloud with point num 722286
Writing point cloud with point num 626948
Writing point cloud with point num 742078
Writing point cloud with point num 707974
Writing point cloud with point num 743140
Writing point cloud with point num 749527
Writing point cloud with point num 750107
Writing point cloud with point num 736130
Writing point cloud with point num 788165

etc

weitsang commented 1 year ago

Remove the debugging messages for now. Can add the flags later.

YoHoSo commented 1 year ago

The debugging message is removed. Should we also remove the progress message?

(base)  young@YoungMacBookPro  ~/local/vivotk   main_fix_69 ±  cargo run --bin vv -- read ./8i_dataset/red_black/ply_b/redandblack_vox10_1510.ply +output=plyb \ 
                                    to_png +input=plyb --output-dir ./tmp/
    Finished dev [unoptimized + debuginfo] target(s) in 0.51s
     Running `target/debug/vv read ./8i_dataset/red_black/ply_b/redandblack_vox10_1510.ply +output=plyb to_png +input=plyb --output-dir ./tmp/`
=======================
read: 0
to_png: 0
=======================
=======================
read: 1
to_png: 0
=======================
=======================
read: 1
to_png: 1
=======================
weitsang commented 1 year ago

Yes. We should follow the Unix CLI design philosophy. Debugging messages should be printed only if user explicitly ask for it.

I have removed it in commit 44087dc