search

nus-vv-streams / vvtk

A toolkit for volumetric video research
MIT License
9 stars 8 forks source link

Rename `to_png` as `render` #13

Closed weitsang closed 1 year ago

weitsang commented 1 year ago

Since we no longer treat generating PNG file as a "convert to" operation, let's rename it to render so that the need to specify camera parameters is clearer.

YoHoSo commented 1 year ago

Now to_png is in the subcommand mode(in vv). Do we need an extra binary for to_png(render)?

weitsang commented 1 year ago

No need. We do vv render ..." instead ofvv to_png .. `

YoHoSo commented 1 year ago

Do you mean we should replace to_png with render and specify the render format(png, mp4, jpg, etc)?

weitsang commented 1 year ago

Yes, just a rename of the name of the subcommand. You are right -- adding a flag to specify the format would be nice (but not priority now). We can render to PNG as default first.

weitsang commented 1 year ago

Fixed in commit 9789794