search

nusCS2113-AY1819S1 / forum

5 stars 0 forks source link

Clarify where should [Test code] in the portfolio link to? #101

Closed Tsuweiquan closed 5 years ago

Tsuweiquan commented 5 years ago

I would like to clarify where should [Test code] link to? image

[Functional code] links to repo sense but what about [Test code]?

okkhoy commented 5 years ago

Reposense reports both functional and testcode. It is covered by this point:

image

Tsuweiquan commented 5 years ago

Alright! So i can just remove [Test Code], as long as my [Functional code] links to the reposense. Thank You Prof!

okkhoy commented 5 years ago

What do you mean you can remove [Test Code]? The instructions indicate that "ignore minor enhancements and link to code from the sample template". Reason:

  1. We expect you to implement one feature, no concept of minor or major (that used to be the case in CS2103 a couple of semesters ago)
  2. The code is already a part of the contribution summary earlier in the document where you link to reposense dashboard.

So there is no reason for you to retain those 2 lines from the template in your PPP. Could you please let me know the cause of confusion, so that I can tweak the instructions (if it is appropriate).

Tsuweiquan commented 5 years ago

Oh this is what i meant by removing [Test Code] image

I understand what you mean now. I have misread this sentence Follow the example in the AddressBook-Level4, but ignore the following two lines in it. I should not include both Minor Enhancement & Code Contributedi in the PPP. Sorry for the confusion!