search

nusCS2113-AY1920S1 / pe-dev-response

0 stars 0 forks source link

fuzzysearch causes crash #14

Open nus-pe-bot opened 4 years ago

nus-pe-bot commented 4 years ago

image.png

inputting a long string into fuzzysearch causes program to crash

Input was: fuzzySearch where the string was 9999999 chars long

[original: nusCS2113-AY1920S1/pe-interim#14]

JokerYan commented 4 years ago

Team's Response

Thank you for your report. We believe this issue is not in scope for the following two reasons.

Firstly, this is certainly not a legitamate user input. This is very different from the user having a typo or wrongly typed in negative numbers for index. It will not affect the user's normal usage.

Secondly, the program is actually not crashed, but keeps calculating. This is because the editDistance algorithm is a O(mn) time complexity, where m and n are the length of the two words compared. This can be very slow when using the long string you inputed. Thus, this is a performance issue instead of the feature flaw. If the user really wants to type in such a long string, he/she should have a good enough computer to run it. In our understanding, perfomance issue is not within the scope of PE.

Thank you again for testing and reporting. Have a nice day.

Duplicate status (if any):

--