search

nusenu / ansible-relayor

An Ansible Role for Tor Relay Operators
GNU General Public License v3.0
245 stars 43 forks source link

add ansible tag runs #180

Open nusenu opened 6 years ago

nusenu commented 6 years ago

this would allow us to test our tags

https://github.com/ahelal/kitchen-ansiblepush#kitchenyml-options

provisioner:
  tags: ...
Lirt commented 6 years ago

Hey Nusenu,

I can see how this can be useful.

For example we can make a test with tag renewkey, at the end of which will be run verifier (serverspec/inspec), which will check if the key is indeed changed and correct.

Besides that I think that we do not need to specify tags in tests unless we want to test something specific like above. We should mainly test tags that we think that may fail when run isolated. Sometimes that happens, when tasks in tag are dependent on previous tasks which registers variables and so on.

Technically to test tags, we will override provisioner in suite and add tags.

nusenu commented 6 years ago

Generally, I agree.

we will have to run a full (no tags) playbook before running the renewkey or reconfigure tags against targets. #176 might be handy then.