search

nushackers / nushackers-site

NUS Hackers website
https://www.nushackers.org
MIT License
43 stars 45 forks source link

Add sign up links to Hackerschool and Hacker Toolbox #592

Closed shenyih0ng closed 1 year ago

shenyih0ng commented 1 year ago

Currently all Hackerschool and Hacker Toolbox events on our websites do not have any way for people to sign up. This PR changes the previous blog_post data field to a sign_up field.

events:
  - topic: Unity for Beginners
    venue: Seminar Room 11 @ COM3-01-20
    sign_up: <sign-up-link>
    date: 2023-08-30T19:00:00
netlify[bot] commented 1 year ago

Deploy Preview for nushackers ready!

Name Link
Latest commit 9e15fd54e65a20e401f2a527d77776c5807540eb
Latest deploy log https://app.netlify.com/sites/nushackers/deploys/6514e14958f0ea0008ab2c31
Deploy Preview https://deploy-preview-592--nushackers.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

shenyih0ng commented 1 year ago

LGTM. I think @tohlh did create a blog post for the first HS session this semester though?

@ravern you're right, but i think it wasn't linked in the .yaml. actl we can still link a blog post with the sign_up field but not sure if that's intuitive. alternatively we can just keep the current blog_post

parth-io commented 1 year ago

Would it be a good idea to leave the blog_post in, if we display an archive of past HS/HT and link the current HS/HT schedule to our Telegram posts instead? I was thinking of linking HS/HT posts on the website to a RSS feed of our current NUS Hackers Telegram channel

Edit: Actually, I don't think there is a need for to distinguish between blog_post and sign_up and maintain two attributes

I'll create a separate thread for this, to explore the purpose of an archive and the value of linking to Telegram

ravern commented 1 year ago

@tohlh and I discussed it yesterday and we're good with just using sign_up links for now. We can remove the blog_post attribute. As for the post that's already there, we can just leave it.

So this PR LGTM