search

nushackers / openhack-submissions

Submissions for OpenHack 2020 (https://openhack.nushackers.org/).
Apache License 2.0
4 stars 0 forks source link

Submission - [shimeilee] #5

Open shimeilee opened 4 years ago

shimeilee commented 4 years ago

Submission Details

Type of Submission:

Link to Pull Requests:

  1. https://github.com/nusmodifications/nusmods/pull/2632
  2. https://github.com/nusmodifications/nusmods/pull/2634
  3. https://github.com/nusmodifications/nusmods/pull/2815

Link to open-source project:

Additional information (optional): Feel free to let me know if the current PRs considered trivial! Will be looking at more issues to work on.

chrisgzf commented 4 years ago

Hey @shimeilee, both PRs (1) and (2) are accepted! 🙂

chaitanyabaranwal commented 4 years ago

Hey @shimeilee, a reminder to submit the third PR in case you forgot. In case you did not get enough time to finish the third PR, no worries, good job on finishing 2 PRs anyway :D

shimeilee commented 4 years ago

Hi @chaitanyabaranwal !! Thanks for the follow up --> I didn't do anything fancy for the last PR though, feel free to reject it!!

chaitanyabaranwal commented 4 years ago

Hey @shimeilee, I think this is fine haha :) Thanks for sharing your work and your OpenHack submission is now accepted!

Please visit https://openhack.nushackers.org/congrats and fill up the form so that we can capture your details for the prizes.

We hope you had fun working on the challenge and we hope you will continue making open-source contributions, even outside of the event! 😃