nushackers / openhack-submissions

Submissions for OpenHack 2020 (https://openhack.nushackers.org/).
Apache License 2.0
4 stars 0 forks source link

Submission - nhzaci #9

Open nhzaci opened 4 years ago

nhzaci commented 4 years ago

Submission Details

Type of Submission:

Link to Pull Requests:

1. 2. 3.

Link to open-source project:

Additional information (optional):

chaitanyabaranwal commented 4 years ago

Hey! The projects looks good so nice job there :) However, you could improve the documentation for both projects. That would make it easier for potential contributors to start working on your project.

Your documentation (the README.md) should ideally have clear instructions on how people can set the project up on their own computers. They obviously need to "reproduce" the project on their own computers if they want to contribute to it :) For FinancialSense, can also add a link where the website is hosted if there's one! We would love for you to make these additions to the project before we accept it, thanks :D

nhzaci commented 4 years ago

Hey! The projects looks good so nice job there :) However, you could improve the documentation for both projects. That would make it easier for potential contributors to start working on your project.

Your documentation (the README.md) should ideally have clear instructions on how people can set the project up on their own computers. They obviously need to "reproduce" the project on their own computers if they want to contribute to it :) For FinancialSense, can also add a link where the website is hosted if there's one! We would love for you to make these additions to the project before we accept it, thanks :D

Hey Chaitanya,

I've updated the README for all the repositories with installation instructions :)

As for FinancialSense, it is not currently hosted as the back-end authentication has yet to be set up and I am still exploring the security aspects of different authentication methods so I have yet to implement one.

Thanks! :)

chrisgzf commented 4 years ago

Hello @nhzaci, thanks for sharing your projects! We like how you experimented with different types of styling frameworks and experimented with them to come up with projects that have a unique look and personality to them. Thanks for sharing your work and your OpenHack submission is now accepted!

Please visit https://openhack.nushackers.org/congrats and fill up the form so that we can capture your details for the prizes.

We hope you had fun working on the challenge and we hope you will continue making open-source contributions, even outside of the event! 😃