nushell / nufmt

MIT License
64 stars 8 forks source link

:memo: Add docs for contributing and private items #26

Closed AucaCoyan closed 1 year ago

AucaCoyan commented 1 year ago

Hello! I took some time between my last PR and this one because I was documenting everything on the code 😍 .

This is the list of contributions, I would like to hear the thoughts of @fdncred and @amtoine about them before merging this PR:

I added these rules because I would like to improve the quality of upcoming contributions. I'm not sure if this is asking too much from the people who want to be involved in the project, as some of the rules may be a bit annoying. Do you see it doable? Do you think we should delete some or all of the clippy lints?

fdncred commented 1 year ago

Maybe we should add a nufmt channel in discord now that we're being more official with this now? I just mention here because it may change some links referenced.

amtoine commented 1 year ago

Maybe we should add a nufmt channel in discord now that we're being more official with this now? I just mention here because it may change some links referenced.

oooh yeah, we have a thread only :+1: if we create a channel, the link might have to change as you said :ok_hand:

AucaCoyan commented 1 year ago

Maybe we should add a nufmt channel in discord now that we're being more official with this now?

I would love to! Tag me if you create it. I have many things to reply, but it is going to be a long conversation if we don't do it on chat 🤣

amtoine commented 1 year ago

@fdncred link to the new #nufmt channel updated in 13ae3b07daa5be520982b6b3459e004e3b0167ce :ok_hand:

AucaCoyan commented 1 year ago

I believe I addressed all the changes you requested, but feel free I you find some more or want to redo something! @amtoine

amtoine commented 1 year ago

i've fixed the links to the Discord in 9123aa3 @AucaCoyan, hoping the commit body explains this well :innocent:

AucaCoyan commented 1 year ago

i've fixed the links to the Discord in 9123aa3 @AucaCoyan, hoping the commit body explains this well 😇

All good to go! Thanks for the fixes!