search

nushell / nufmt

MIT License
64 stars 8 forks source link

Check newline at the end of the file #27

Closed AucaCoyan closed 1 year ago

AucaCoyan commented 1 year ago

Hi! It's me again. I added the check of the new line at the end of the file. If, for some reason, the output of nufmt doesn't end on a new line, add it.

I remember somebody asking for a config that opt out of this feature. I research some popular formatters and all of them add a new line at the end of the file. Is there a case where is not recommended? \n

amtoine commented 1 year ago

there are a bunch of duplicate commmits here with #26, namely 4b97279ad6822b916dba66a3ea1272387d0cc371..c1f18dd1d6e3e4512a12dbd8f442108f19a378fa but we're really only interested in 581f3b37e5398c5b2046d64820c8be9871b76e19..1b6120865c3571722c119bf213295d9488e14edf :open_mouth:

i doubt we can properly open a PR on top of another unmerged one in GitHub...

@AucaCoyan can you reopen this either

?