Closed amtoine closed 1 year ago
Hello! This test is for
If at the end of the file are there any multiple empty lines, just leave 1 line I think we can remove it since format string doesn't do this from now.
Should we test the function format_file? we can write a file, format it and the test it. After that, we can delete the file. What do you think? We can move that to another time too!
As it is now, it is very valuable! Later we would need to fix the failing test, but nonetheless is a step forward! I'm allright with a merge right now 😄
greeeeat, thanks @AucaCoyan for the review :relieved:
cc/ @AucaCoyan
this PR moves the
add_newline_at_end_of_file
outside offormat_inner
. the responsibility is not those offormat_single_file
,format_string
does not add a newline to all strings anymore.tests have been fixed :+1:
one thing i'm struggling with is the following test
which does not pass without the
\n
inexpected
:thinking: any idea? :confused: