Closed amtoine closed 8 months ago
Later we would need to fix the failing test, but nonetheless is a step forward! I'm allright with a merge right now 😄
Originally posted by @AucaCoyan in https://github.com/nushell/nufmt/issues/31#issuecomment-1602741114
the test here is the following
#[test] fn remove_additional_lines() { let input = "let one = 1\n\n\n"; let expected = "let one = 1\n"; run_test(input, expected); }
i think it should become
#[test] fn remove_additional_lines() { let input = "let one = 1\n\n\n"; let expected = "let one = 1"; run_test(input, expected); }
Note the is no more newlines at the end of expected => this was moved out of the responsibility of format_inner in #31.
expected
format_inner
The PR #35 solves this issue 🎉
Originally posted by @AucaCoyan in https://github.com/nushell/nufmt/issues/31#issuecomment-1602741114
the test here is the following
i think it should become