Closed IogaMaster closed 10 months ago
Do i need to fix the format issue, the pr doesn't contain rust code.
weird that we'd have a fmt problem here where there's no rust code. maybe we should have a separate pr to fix the fmt issue since it's unrelated to this pr. if something crazy happened and we had to revert this PR, we probably wouldn't want to revert the fmt change.
I'll see about fixing that in a separate pr
Also would we want direnv for automatic runs of nix develop
when applicable.
https://github.com/direnv/direnv
Also would we want direnv for automatic runs of
nix develop
when applicable. https://github.com/direnv/direnv
I'm agnostic on direnv. I know some people use it and love it. Others don't. One key that we always have to keep in mind is that nufmt, and the nushell family of programs, aren't just Linux or Mac programs. We need to continue to try to be as cross-platform as possible and support Windows.
Nix is not on windows but it would be just for mac and linux devs same as the direnv thing as it would use nix-direnv Windows dev's would work the same way they would normally.
I like to have Nix be optional to developing a project, just a nice addition.
I want to remove the merge commit first
I like to have Nix be optional to developing a project, just a nice addition.
Right. I'm not objecting to this as an optional thing at all. Just reminding onlookers that we're cross-platform, so every PR will be seen in that light.
Thanks
Here is a basic flake for the project.
Features:
nix develop
and you have the locked version of Rust and rust-analyzerLet me know any other changes that need to be made