search

nushell / nufmt

MIT License
64 stars 8 forks source link

Revert "Check Nix flake workflow (#46)" #51

Closed amtoine closed 10 months ago

amtoine commented 10 months ago

related to

cc/ @IogaMaster

Description of changes

this PR reverts #46.

without any justification for this, i'd rather revert the changes :yum:

IogaMaster commented 10 months ago

This makes sure the flake is functional and doesn't error when someone wants to enter the devshell or build nufmt with nix.

amtoine commented 10 months ago

we'll decide the fate of that PR from https://github.com/nushell/nufmt/pull/52 :wink:

IogaMaster commented 10 months ago

53 Happens anyway because the flake syntax is valid but the package itself built for macos needs Iokit to build.

IogaMaster commented 10 months ago

So if we dont merge #52 then I will write a check that runs on macos to test builds there as well.

amtoine commented 10 months ago

46 has been sorted out, thanks @IogaMaster for the explaining :pray: